| Summary: | Improving koha-list and koha-create | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Robin Sheat <robin> |
| Component: | Packaging | Assignee: | Robin Sheat <robin> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | chris, jcamins, magnus, paul.poulain |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 6913 - change how ports are handled by koha-create
Bug 6913 - change how ports are handled by koha-create Follow-up patch Revised follow-up patch Bug 6913: More options for koha-create and koha-remove Bug 6913 - change how ports are handled by koha-create Bug 6913: More options for koha-create and koha-remove |
||
|
Description
Robin Sheat
2011-09-25 22:33:25 UTC
Created attachment 5583 [details] [review] Bug 6913 - change how ports are handled by koha-create This does two things: * Allows OPACPORT to be specified to change the default OPAC port, * removes the port number from the ServerName directive, as it's already handled by the VirtualHost declaration. Created attachment 5800 [details] [review] Bug 6913 - change how ports are handled by koha-create This does two things: * Allows OPACPORT to be specified to change the default OPAC port, * removes the port number from the ServerName directive, as it's already handled by the VirtualHost declaration. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 5803 [details] [review] Follow-up patch This follow-up patch has not been signed off yet! Only the first one. Bug 6913: More options for koha-create and koha-remove This commit makes koha-create more flexible by adding a number of command-line and configuration options. The biggest change is to add support for pre-determined MySQL credentials using a file in /etc/koha/passwd (for security reasons, if you use this feature, make sure the file is not world-readable). The configuration file has the following format: instance:user:password:database The database is optional, but the other two are both required if you want to specify MySQL credentials. If no credentials are specified for a given instance, the standard koha_instance username and an auto-generated password are used. The following additional command line options are now available: * --use-db - use a pre-existing database, see also --database * --database - specify the name of the mysql database (still defaults to koha_instance) * --passwdfile - specify a custom (Koha) passwd file for MySQL credentials The following additional variables are now available (for use in koha-sites.conf or a custom config file): * OPACPORT (previously added but not documented) - port on which the OPAC should be served * OPACPREFIX - prefix for the OPAC's virtual host * OPACSUFFIX - suffix for the OPAC's virtual host This commit also adds the --keep-mysql option to koha-remove, which, if specified, will prevent koha-remove from deleting the database or MySQL user when removing an instance. Created attachment 5821 [details] [review] Revised follow-up patch This patch corrects an error in the mysql command line arguments that caused problems with some versions of MySQL. This patch still has not been signed off. The last comment from Jared seems to imply that patch status should be Needs Signoff, so I'm setting it that way. Updating Version : This ENH will be for Koha 3.8 Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) Created attachment 6890 [details] [review] Bug 6913: More options for koha-create and koha-remove This commit makes koha-create more flexible by adding a number of command-line and configuration options. The biggest change is to add support for pre-determined MySQL credentials using a file in /etc/koha/passwd (for security reasons, if you use this feature, make sure the file is not world-readable). The configuration file has the following format: instance:user:password:database The database is optional, but the other two are both required if you want to specify MySQL credentials. If no credentials are specified for a given instance, the standard koha_instance username and an auto-generated password are used. The following additional command line options are now available: * --use-db - use a pre-existing database, see also --database * --database - specify the name of the mysql database (still defaults to koha_instance) * --passwdfile - specify a custom (Koha) passwd file for MySQL credentials The following additional variables are now available (for use in koha-sites.conf or a custom config file): * OPACPORT (previously added but not documented) - port on which the OPAC should be served * OPACPREFIX - prefix for the OPAC's virtual host * OPACSUFFIX - suffix for the OPAC's virtual host This commit also adds the --keep-mysql option to koha-remove, which, if specified, will prevent koha-remove from deleting the database or MySQL user when removing an instance. Rebased on latest Master as of 20 December 2011 Created attachment 6892 [details] [review] Bug 6913 - change how ports are handled by koha-create This does two things: * Allows OPACPORT to be specified to change the default OPAC port, * removes the port number from the ServerName directive, as it's already handled by the VirtualHost declaration. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 6893 [details] [review] Bug 6913: More options for koha-create and koha-remove This commit makes koha-create more flexible by adding a number of command-line and configuration options. The biggest change is to add support for pre-determined MySQL credentials using a file in /etc/koha/passwd (for security reasons, if you use this feature, make sure the file is not world-readable). The configuration file has the following format: instance:user:password:database The database is optional, but the other two are both required if you want to specify MySQL credentials. If no credentials are specified for a given instance, the standard koha_instance username and an auto-generated password are used. The following additional command line options are now available: * --use-db - use a pre-existing database, see also --database * --database - specify the name of the mysql database (still defaults to koha_instance) * --passwdfile - specify a custom (Koha) passwd file for MySQL credentials The following additional variables are now available (for use in koha-sites.conf or a custom config file): * OPACPORT (previously added but not documented) - port on which the OPAC should be served * OPACPREFIX - prefix for the OPAC's virtual host * OPACSUFFIX - suffix for the OPAC's virtual host This commit also adds the --keep-mysql option to koha-remove, which, if specified, will prevent koha-remove from deleting the database or MySQL user when removing an instance. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA comment * nothing to say about the code, everything consistent and clearly written * haven't tested it myself, but chris_c is a trustable tester passed QA Patch pushed, versionned for 3.8 as this patch contains improvements that should be announced & explained widely. chris_n, is you disagree, let me know There have been no further reports of problems so I am marking this bug resolved. |