Summary: | koha_perl_deps.pl color option changes user's shell prompt | ||
---|---|---|---|
Product: | Koha | Reporter: | Greg Barniskis <gbarniskis> |
Component: | Installation and upgrade (command-line installer) | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | Linux | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
proposed 6914 patch
patch attempt 2 Bug 6914 - fixes for the color option of koha_perl_deps.pl |
Description
Greg Barniskis
2011-09-25 22:51:57 UTC
Created attachment 5584 [details] [review] proposed 6914 patch Comment on attachment 5584 [details] [review] proposed 6914 patch The first patch file attached here (2011-09-25 23:31 UTC) is flawed because I was more intent on learning git commands and work flow than the code. The 'reset' should be after the footer print line. Sorry, I will send a corrected patch. Created attachment 5591 [details] [review] patch attempt 2 with correct ordering of the color reset Created attachment 6511 [details] [review] Bug 6914 - fixes for the color option of koha_perl_deps.pl Reset the terminal color mode after reporting (to avoid polluting the user's shell), and use blue instead of white for the report header and footer. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> affects koha_perl_deps.pl only, which is primarily only used turning install or trouble shooting. just changes colors, which are entirely cosmetic. Marking as Passed QA patch pushed, please test Included in 3.6 prior to 3.6.5. |