Bug 6915

Summary:	koha_perl_deps.pl truncates long module names at 26 chars
Product:	Koha	Reporter:	Greg Barniskis <gbarniskis>
Component:	Installation and upgrade (command-line installer)	Assignee:	Greg Barniskis <gbarniskis>
Status:	CLOSED FIXED	QA Contact:	Bugs List <koha-bugs>
Severity:	minor
Priority:	PATCH-Sent (DO NOT USE)	CC:	chris, magnus, paul.poulain
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	patch for 6915 Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl

Description Greg Barniskis 2011-09-25 23:53:19 UTC

koha_perl_deps.pl doesn't correctly report module names longer than 26 characters, truncating (at least) CGI::Session::Driver::memcached, CGI::Session::Serialize::yaml and MARC::Crosswalk::DublinCore.

Test: perl koha_perl_deps.pl -a reports full module names?

Proposed fix: modify the report's format statement and surrounding header and footer prints, which apply generally too much white space. A better fix might make the whole thing more flexible than fixed width columns.

Patch coming as soon as git config stops hating on me.

Comment 1 Greg Barniskis 2011-09-26 17:20:15 UTC Comment hidden (obsolete)

Created attachment 5593 [details] [review]
patch for 6915

Comment 2 Magnus Enger 2011-10-06 14:08:01 UTC Comment hidden (obsolete)

Created attachment 5739 [details] [review]
Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl

Widen module name allowance in the format statement, adjust other
columns to be generous but not-so-much as before, modify report
header and footer print statements to align and clarify. Very very
long module names or version numbers are still subject to possible
truncation.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>

Sign off comment: With this patch module names are not truncated, which is an
improvement. Lines are still too long to fit an 80 column display, and so they
wrap around, but tht is a minor annoyance compared to the truncated names.

Comment 3 Paul Poulain 2011-10-14 10:21:43 UTC

QA comment :
  * test plan not detailled enough. Complete version with an example :

Before the patch, ./koha_perl_deps.pl -i says:
CGI::Session::Serialize::y                  4.26                                  4.2                      Yes

After the patch, it says:
CGI::Session::Serialize::yaml                 4.26              4.2                     Yes
  * agreed with magnus comment, but also noticing that the patch was not intended to fix the 80 column display
  * small changes in the code, nothing to comment, passed QA

Comment 4 Paul Poulain 2011-10-14 10:22:05 UTC

Created attachment 5888 [details] [review]
Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl

Widen module name allowance in the format statement, adjust other
columns to be generous but not-so-much as before, modify report
header and footer print statements to align and clarify. Very very
long module names or version numbers are still subject to possible
truncation.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>

Sign off comment: With this patch module names are not truncated, which is an
improvement. Lines are still too long to fit an 80 column display, and so they
wrap around, but tht is a minor annoyance compared to the truncated names.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Comment 5 Chris Cormack 2011-10-15 01:01:48 UTC

Pushed, please test

Comment 6 Jared Camins-Esakov 2012-12-31 00:21:09 UTC

There have been no further reports of problems so I am marking this bug resolved.