Bug 6938

Summary: The "Subscription History" public and private note fields have gone missing
Product: Koha Reporter: Robin Sheat <robin>
Component: SerialsAssignee: Robin Sheat <robin>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: major    
Priority: PATCH-Sent (DO NOT USE) CC: chris, colin.campbell, katrin.fischer, koha.sekjal, paul.poulain
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 6938 - replace two subscription fields that were incorrectly removed
Bug 6938 - replace two subscription fields that were incorrectly removed

Description Robin Sheat 2011-09-29 04:55:50 UTC
The commit that removed them was this one:


It has no associated bug or RM signoff, provides no migration path away from using those fields, and was wrong in the description (they're not redundant: the removed fields are associated with the subscription history table, not the subscription one.)

It's debatable whether we should have that many note fields, but for now we will, until something that removes them properly can be implemented.
Comment 1 Robin Sheat 2011-09-29 05:08:14 UTC Comment hidden (obsolete)
Comment 2 Colin Campbell 2011-09-29 10:33:42 UTC
Signed off fields only appear in edit when manual history is selected.
data entered is correctly saved and displayed
Comment 3 Paul Poulain 2011-10-12 16:04:24 UTC
Created attachment 5860 [details] [review]
Bug 6938 - replace two subscription fields that were incorrectly removed

The "Note for OPAC" and "Note for staff" fields in subscriptions were
removed, but they are their own fields in the database and display in
other places too. This patch puts them back so that they can once again
be edited.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 4 Paul Poulain 2011-10-12 16:06:47 UTC
QA comment
  * patch conflicted with owen recent change on display, i've fixed the conflict
  * this patch also added some minor but not announced reindenting.
  * do what it announced, small template changes

passed QA

For RM: this contains some strings so conflicts with string freeze but as it fixes a big regression, I vote for immediate inclusion (& increase the severity of the bug)
Comment 5 Ian Walls 2011-10-12 21:07:31 UTC
Template-only change to reintroduce display of a few lost fields.  Easy to read, marking as Passed QA.

Yes, this does introduce new strings, and this doesn't seem to be a critical problem.  RM, your call as to whether to integrate this now, or wait for 3.6.1.
Comment 6 Chris Cormack 2011-10-12 22:01:33 UTC
Will hold over for 3.6.1
Comment 7 Chris Cormack 2011-10-12 22:04:59 UTC
Actually, if any translators want to say, go ahead and push, im happy to do that also.
Comment 8 Katrin Fischer 2011-10-13 07:34:56 UTC
I think bringing back missing information is important. +1 for pushing this.
Comment 9 Chris Cormack 2011-10-13 09:00:48 UTC
Pushed, please test
Comment 10 Katrin Fischer 2012-02-19 12:41:27 UTC
All notes (staff note, opac note, staff history note, opac history note) correctly show on the summary tab.