| Summary: | Cannot sort the results of a tag search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, nengard, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 6950: Make the resort working when searching for a tag
Bug 6950: Hide the resort option when searching for a tag Bug 6950: Hide the resort option when searching for a tag [Signed-off] Bug 6950: Hide the resort option when searching for a tag Bug 6950: Hide the resort option when searching for a tag [PASSED QA] Bug 6950: Hide the resort option when searching for a tag |
||
|
Description
Owen Leonard
2011-09-30 15:40:50 UTC
Created attachment 37284 [details] [review] Bug 6950: Make the resort working when searching for a tag If you click a link from the Tag Cloud, the results page offers the usual select menu to resort your results. However, doing so resubmits the search as a standard keyword search. Test plan: 1/ Click on a tag 2/ Use the resort dropdown list to change the sort 3/ Confirm that the results are relevant. Applied patch In OPAC, went to Tag cloud, clicked on tag 'Geneva' Two biblios are tagged with Geneva: Rollo in Geneva by Abbott, Jacob, 1803-1879. Mystery at Geneva An Improbable Tale of Singular Happenings by Macaulay, Rose, 1881-1958. Seems to be sorted by Author ( Abbot < Macaulay ) The link reads: ...cgi-bin/koha/opac-search.pl?tag=Geneva&q=Geneva At top right, I click on sorting by Title. This should change the display (Mystery < Rollo) Page reloads I have still first Rollo, then Mystery The link reads now: /cgi-bin/koha/opac-search.pl?idx=kw&q=Geneva&sort_by=title_az&tag=Geneva&addto=Add+to...&biblionumber=4673&biblionumber=44150&newtag44150= Created attachment 37299 [details] [review] Bug 6950: Hide the resort option when searching for a tag If you click a link from the Tag Cloud, the results page offers the usual select menu to resort your results. However, doing so resubmits the search as a standard keyword search. Test plan: 1/ Click on a tag 2/ Confirm that the resort dropdown list does not appear. (In reply to Marc Véron from comment #2) Sorry about that, it was a very naive approach and cannot work (I am sure I have tested!!....) The last patch only removes the resort option. Hi Jonathan,
Sorry, the sort drop-down is still visible.
Seems that the var tag is not defined for the template.
I think it could be fixed after the following lines in opac/opac-search.pl, around line 347:
my $tag;
$tag = $params->{tag} if $params->{tag};
I added following line:
$template->param(tag => $tag);
This way, the sorting drop down disappears as expected if tags are displayed. With a 'normal' search, sorting drop down appears.
What do you think about?
Marc
Created attachment 37324 [details] [review] Bug 6950: Hide the resort option when searching for a tag If you click a link from the Tag Cloud, the results page offers the usual select menu to resort your results. However, doing so resubmits the search as a standard keyword search. Test plan: 1/ Click on a tag 2/ Confirm that the resort dropdown list does not appear. (In reply to Marc Véron from comment #5) Marc, Yes sorry (again) I forgot to add the pl changes to the last patch! Created attachment 37327 [details] [review] [Signed-off] Bug 6950: Hide the resort option when searching for a tag If you click a link from the Tag Cloud, the results page offers the usual select menu to resort your results. However, doing so resubmits the search as a standard keyword search. Test plan: 1/ Click on a tag 2/ Confirm that the resort dropdown list does not appear. Dropdown list disappears with tags as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 37512 [details] [review] Bug 6950: Hide the resort option when searching for a tag If you click a link from the Tag Cloud, the results page offers the usual select menu to resort your results. However, doing so resubmits the search as a standard keyword search. Test plan: 1/ Click on a tag 2/ Confirm that the resort dropdown list does not appear. Dropdown list disappears with tags as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 37513 [details] [review] [PASSED QA] Bug 6950: Hide the resort option when searching for a tag If you click a link from the Tag Cloud, the results page offers the usual select menu to resort your results. However, doing so resubmits the search as a standard keyword search. Test plan: 1/ Click on a tag 2/ Confirm that the resort dropdown list does not appear. Dropdown list disappears with tags as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> And another one bites the dust... :) Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.6 *** Bug 10813 has been marked as a duplicate of this bug. *** |