| Summary: | Existing extended patron attributes are shown on patron screens even when ExtendedPatronAttributes is disabled | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Patrons | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, gmcharlt, koha.sekjal |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed fix
[SIGNED-OFF] Fix for Bug 6980, Patron attributes are shown when ExtendedPatronAttributes is disabled |
||
|
Description
Owen Leonard
2011-10-05 20:00:16 UTC
Created attachment 5746 [details] [review] Proposed fix This patch adds a check for the value of the ExtendedPatronAttributes preference to the scripts and corresponding logic to the templates controlling the sidebar menu. The patch also corrects a duplication of attributes code in moremember.pl To test: Add some extended patron attribute data to a patron record, then turn off the ExtendedPatronAttributes preference. Before this patch the data will display in the left-hand sidebar of pages like circulation.pl and moremember.pl. After the patch display of the data will be shown or not according to whether ExtendedPatronAttributes is on or off. Created attachment 5989 [details] [review] [SIGNED-OFF] Fix for Bug 6980, Patron attributes are shown when ExtendedPatronAttributes is disabled This patch adds a check for the value of the ExtendedPatronAttributes preference to the scripts and corresponding logic to the templates controlling the sidebar menu. The patch also corrects a duplication of attributes code in moremember.pl Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) Added extended patron attributes in configuration, turned ExtendedPatronAttributes on 2) Altered patron details, added values for patron attributes > Verified patron attributes show show correctly 3) Turned off ExtendedPatronAttributes > Verified patron attributes were hidden everywhere All template logic is good and clean, and the supporting params are now more logically and consistently treated. Marking as Passed QA. Pushed, please test |