Summary: | Don't show MARC21 tag documentation links for NORMARC | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Cataloging | Assignee: | Magnus Enger <magnus> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, dev_patches, koha.sekjal |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 6982 - Don't show MARC tag documentation links for NORMARC
[SIGNED-OFF] Bug 6982 - Don't show MARC tag documentation links for NORMARC |
Description
Magnus Enger
2011-10-06 18:11:01 UTC
Hm, looks like the MARC21 links are shown for UNIMARC as well - does anyone using UNIMARC have an opinion about hiding them for UNIMARC? same feeling for UNIMARC. Created attachment 5765 [details] [review] Bug 6982 - Don't show MARC tag documentation links for NORMARC Links to UNIMARC documentation were being shown when marcflavour = NORMARC. This patch hides the doc link functionality for NORMARC by hiding: 1. The checkbox for turning doc links on/off 2. The hyperlinked questionmarks This patch does not hide e.g. the JavaScript functions related to the doc link functionality, in order to make it easy to add doc links for NORMARC in the future (hopefully). The doc link functionality was passing a variable called MARC21 (based on the contents of the marcflavour syspref) to the template and testing the value of this to decide if MARC21 or UNIMARC doc links were to be shown. I have replaced this variable with he standard/full marcflavour syspref, in order to make it possible to test for more then two MARC dialects. To test: - Set the marcflavour syspref to MARC21, NORMARC and UNIMARC, one after the other. - Check that correct doc links are shown for MARC21 and UNIMARC on the cataloguing screen, and that no checkbox and no doc links are displayed for NORMARC. Sorry, I was mistaken in thinking that the wrong doc links were shown for UNIMARC. This patch only addresses NORMARC. Created attachment 5940 [details] [review] [SIGNED-OFF] Bug 6982 - Don't show MARC tag documentation links for NORMARC Links to UNIMARC documentation were being shown when marcflavour = NORMARC. This patch hides the doc link functionality for NORMARC by hiding: 1. The checkbox for turning doc links on/off 2. The hyperlinked questionmarks This patch does not hide e.g. the JavaScript functions related to the doc link functionality, in order to make it easy to add doc links for NORMARC in the future (hopefully). The doc link functionality was passing a variable called MARC21 (based on the contents of the marcflavour syspref) to the template and testing the value of this to decide if MARC21 or UNIMARC doc links were to be shown. I have replaced this variable with he standard/full marcflavour syspref, in order to make it possible to test for more then two MARC dialects. To test: - Set the marcflavour syspref to MARC21, NORMARC and UNIMARC, one after the other. - Check that correct doc links are shown for MARC21 and UNIMARC on the cataloguing screen, and that no checkbox and no doc links are displayed for NORMARC. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described - thx for the great test plan! Simplifies perl code, and consistently adds more robust support for alternate MARC formats in template. Marking as Passed QA. Hopefully we can find a good source for NORMARC documentation that can be included! Pushed, please test Works in 3.6.4. |