Summary: | Encoding problem in opac-showmarc | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | OPAC | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5616 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Patch
Patch Revised patch Revised patch screenshot before patch screenshot after patch was applied Revised patch [SIGNED-OFF] Bug 6996: Encoding problem in opac-showmarc Bug 6996: Encoding problem in opac-showmarc |
Description
Marcel de Rooy
2011-10-10 10:13:53 UTC
Created attachment 5822 [details] [review] Patch Created attachment 5823 [details] [review] Patch Small additional adjustment Note that it is not needed to decode data from LibXSLT if the stylesheet contains the instruction to use UTF8. (See CPAN.) Extending the code therefore with a test on utf8 flag. Created attachment 5827 [details] [review] Revised patch Last revision ;) Created attachment 5828 [details] [review] Revised patch Oops, wrong version.. Created attachment 5831 [details]
screenshot before patch
Hi Marcel,
I used a record with German umlauts for testing and made sure, they were correctly cataloged. The umlauts show correctly on the other views, but on plain MARC view they are broken before and after applying for patch. Do I miss something?
Created attachment 5832 [details]
screenshot after patch was applied
Hi Katrin, Thanks for testing. I guess that your problem had to do with using only characters with accents from the Latin range. I could repeat your problem with some umlauts on vowels. When I adding non-Latin unicode chars, the display was correct again. The Latin chars only do not set the UTF8 flag. The other chars do set the UTF8 flag. I corrected the problem by specifically adding utf8 on the output handle (giving perl no chance to make the wrong guess). New patch forthcoming. Created attachment 5850 [details] [review] Revised patch Created attachment 5864 [details] [review] [SIGNED-OFF] Bug 6996: Encoding problem in opac-showmarc Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No more encoding problems spotted. QA comment : * good description * works also with UNIMARC (and the problem also existed in UNIMARC) Marking passed QA Created attachment 5956 [details] [review] Bug 6996: Encoding problem in opac-showmarc Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No more encoding problems spotted. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Pushed, please test |