| Summary: | koha-remove leaves system in inconsistent state if there is an error | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
| Component: | Packaging | Assignee: | Jared Camins-Esakov <jcamins> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | dpavlin, koha.sekjal, paul.poulain, robin |
| Version: | 3.6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 6929 | ||
| Attachments: |
Bug 6997: Koha-remove leaves system in inconsistent state
Bug 6997: Koha-remove leaves system in inconsistent state |
||
|
Description
Jared Camins-Esakov
2011-10-10 11:49:41 UTC
Created attachment 5825 [details] [review] Bug 6997: Koha-remove leaves system in inconsistent state If you accidentally delete one of the files that koha-remove is supposed to remove, when koha-remove reaches that point in the script, it will die, leaving later removal steps undone. This patch fixes the problem by checking for the existence of each file prior to deleting it, so that short of an actual problem with removing the file, the script can continue. Note that the fix for bug 6929 is also needed to prevent any problems with stopping Zebra from killing koha-remove. Created attachment 6396 [details] [review] Bug 6997: Koha-remove leaves system in inconsistent state Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Handles all the cases, as far as I can tell, wrapping in conditional checks. Only affects packages in a very specific case, so little chance of regression anywhere in the system. marking passed QA patch pushed, please test (Note i haven't tested this patch myself, reading it seems OK though) |