| Summary: | Make all strings translatable in marc21_field_007.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Frédérick Capovilla <fcapovilla> |
| Component: | I18N/L10N | Assignee: | Frédérick Capovilla <fcapovilla> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | cnighswonger, koha.sekjal, paul.poulain |
| Version: | 3.6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Make all strings translatable in marc21_field_007.tt
Make all strings translatable in marc21_field_007.tt (corrected) [SIGNED-OFF] Make all strings translatable in marc21_field_007.tt |
||
|
Description
Frédérick Capovilla
2011-10-14 20:26:10 UTC
Comment hidden (obsolete)
Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) I have tested this on current master using following steps: - apply patch - perl translate update de-DE - check for new strings, like "b- Braille" I was not able to find the new strings in the updated po file. Not sure what the problem is, as the patch looks logical to me. Created attachment 5955 [details] [review] Make all strings translatable in marc21_field_007.tt (corrected) It seems the translate script doesn't like when quotes are mixed in multiline javascript strings. Adding line-breaks so the translation is on its own line seems to fix the problem. Corrected patch attached. Created attachment 5994 [details] [review] [SIGNED-OFF] Make all strings translatable in marc21_field_007.tt http://bugs.koha-community.org/show_bug.cgi?id=7033 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan: - apply patch - update po files using 'perl translate update <language-code> - check po files for new strings from 007 plugin - translate some / all of them - update templates with changed po files 'perl translate install <language-code> - verify 007 still works and got translated Updating version : This ENH could be in Koha 3.8 Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) Lot of work. Did you run code over the code? ;) If so, I could QA that for you.. QA Comment: This large patch only extensively covers the marc21 007 template. Looks good to me. Patch pushed, please test. I also think it's a bug, not an ENH, so I set the severity accordingly and add to rel_3_6 to have chris_n applying the patch if needed Note I haven't signed this patch, as I can't test it properly (my test DB is unimarc) In the future, please include "Bug XXXX" in the first line of the commit message. Thanks, Chris 3.4.x/3.6.x Release Maintainer This was included in the 3.6 branch prior to 3.6.4. |