Bug 7042

Summary: Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Command-line UtilitiesAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: minor    
Priority: PATCH-Sent (DO NOT USE) CC: chris, ian.bays, koha.sekjal
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Patch
Sign-off patch

Description Marcel de Rooy 2011-10-17 09:45:01 UTC 
Improving the cleanup_database.pl script in two aspects:
1) In some cases CGI::Session seems to place quotes around the atime and ctime data in the a_session field. Two regexps now take this into account.
2) If the --sessdays parameter is used, the --sessions parameter is now implicitly enabled too.

With thanks to Ian Bays and Tom Hanstra.
Comment 1 Marcel de Rooy 2011-10-17 09:48:54 UTC Comment hidden (obsolete)
Comment 2 Ian Bays 2011-10-20 08:20:19 UTC 
Created attachment 6006 [details] [review]
Sign-off patch
Comment 3 Marcel de Rooy 2011-10-20 08:22:25 UTC 
(In reply to comment #2)
> Created attachment 6006 [details] [review]
> Sign-off patch

Great!
Comment 4 Ian Walls 2011-10-20 13:15:38 UTC 
Makes commandline too more flexible (quotes are regexed with ?, so all previous matches will continue, and new ones can be detected), and more intuitive (don't have to specify two params for sessions).  Marking as Passed QA.
Comment 5 Chris Cormack 2011-10-20 15:42:45 UTC 
Excellent work, pushed