Bug 7043

Summary:	masthead_search id used twice in template
Product:	Koha	Reporter:	Nicole C. Engard <nengard>
Component:	OPAC	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Bugs List <koha-bugs>
Severity:	normal
Priority:	PATCH-Sent (DO NOT USE)	CC:	chris, koha.sekjal
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Proposed fix [SIGNED-OFF] Fix for Bug 7043 - masthead_search id used twice in template

Description Nicole C. Engard 2011-10-17 13:48:18 UTC

masthead_search is the ID of two selected on the OPAC - IDs should be unique.



<select name="idx" id="masthead_search" class="left" style="max-width: 10em; width: 10em;">

<select name="limit" id="masthead_search" class="left" style="max-width: 10em; width: 10em;">

Comment 1 Katrin Fischer 2011-10-17 14:07:41 UTC

If someone is already in there... 

it would be nice if the style could be moved into the CSS files, so that width can be changed easier.

Comment 2 Nicole C. Engard 2011-10-17 14:09:45 UTC

I was going to edit the ID bit, but don't know much about moving things to the CSS so I'll leave this one to Owen to make it just right :)

Nicole

Comment 3 Owen Leonard 2011-10-17 15:54:18 UTC Comment hidden (obsolete)

Created attachment 5933 [details] [review]
Proposed fix

Changing ID of library selector and moving inline styles to the CSS.

Comment 4 Nicole C. Engard 2011-10-17 15:57:40 UTC

Created attachment 5934 [details] [review]
[SIGNED-OFF] Fix for Bug 7043 - masthead_search id used twice in template

Changing ID of library selector, and moving inline styles to
the CSS as requested by kf in the bug comments.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>

Comment 5 Ian Walls 2011-10-17 16:09:23 UTC

Simple template only change, improves compliance with standards.  No string changes.  Marking as Passed QA.

Comment 6 Chris Cormack 2011-10-18 03:08:01 UTC

Pushed to master, please test

Comment 7 Katrin Fischer 2011-11-27 21:47:35 UTC

Checked on current HEAD. 
OpacAddMastheadLibraryPulldown has to be turned on to see select_library id in the source code.