Bug 7044

Summary:	branch selector in OPAC not selecting
Product:	Koha	Reporter:	Nicole C. Engard <nengard>
Component:	OPAC	Assignee:	Nicole C. Engard <nengard>
Status:	CLOSED FIXED	QA Contact:	Bugs List <koha-bugs>
Severity:	critical
Priority:	PATCH-Sent (DO NOT USE)	CC:	chris, koha.sekjal, paul.poulain
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 7044 OPAC Branch Selector Fix Signed-off patch

Description Nicole C. Engard 2011-10-17 13:53:19 UTC

When you have the branch selector turned on it's not selecting the right branch.

Line 83 of masthead.inc: <option select="selected"

That should be <option selected="selected"

Comment 1 Nicole C. Engard 2011-10-17 14:04:46 UTC

Created attachment 5921 [details] [review]
Bug 7044 OPAC Branch Selector Fix

There was a typo in the OPAC branch selector added by
the OpacAddMastheadLibraryPulldown preference where the
current branch wasn't selected. This patch fixes that typo.

Comment 2 Nicole C. Engard 2011-10-17 14:07:12 UTC

I forgot to mention in my commit that Owen is the one who told me how to fix this!! Thanks Owen.

Comment 3 Owen Leonard 2011-10-17 15:25:53 UTC

Created attachment 5930 [details] [review]
Signed-off patch

Before applying the patch: After performing search from the search bar with a branch selected, the selector wouldn't "remember" which branch you selected when displaying search results. After the patch this works correctly.

My bad for not catching this when I QA'ed the patch which introduced this.

Comment 4 Ian Walls 2011-10-17 15:52:54 UTC

Simple fix, template only, easy to read, no string changes.  Marking Passed QA

Comment 5 Chris Cormack 2011-10-17 20:13:08 UTC

Speedy work people well done, pushed, please test