Summary: | Item form on order receive has lots of blank space | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, magnus |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/acqui/orderreceive.pl?ordernumber=65&invoice=something&gst=0&supplierid=11 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
screenshot
Bug 7049: Item form on order receive has lots of blank space Bug 7049: [SIGNED-OFF] Item form on order receive has lots of blank space |
Corresponding change to the item form for AcqCreateItem = on order was: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=9a2fd1bb7ed9e4a9a04d603c7fefb51163ac0424 Created attachment 5943 [details] [review] Bug 7049: Item form on order receive has lots of blank space The item form on the order receive page (AcqCreateItem = on receive) contains a lot of blank space which makes it hard to read and fill out. To test: - set AcqCreateItem = on receive - create basket, order something, receive shipment - check item form is nicely formatted and doesn't include lots of blank space Note: It will be easier to test if you have an ACQ framework created to hide some unnecessary subfields, because the hidden fields create the blank space. Created attachment 5976 [details] [review] Bug 7049: [SIGNED-OFF] Item form on order receive has lots of blank space The item form on the order receive page (AcqCreateItem = on receive) contains a lot of blank space which makes it hard to read and fill out. To test: - set AcqCreateItem = on receive - create basket, order something, receive shipment - check item form is nicely formatted and doesn't include lots of blank space Note: It will be easier to test if you have an ACQ framework created to hide some unnecessary subfields, because the hidden fields create the blank space. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Created an ACQ framework and hid some of the fields (hidden = 5). Before the patch there were gaps between the fields as shown in the screenshot from Katrin. After the patch fields line up nicely, with no extra space between them. Just moves hidden styling out of div an into <li> that wraps it, thereby removing extra spacing. Marking as Passed QA Template only change, not introducing any new strings pushed |
Created attachment 5942 [details] screenshot The item form on the order receive page (AcqCreateItem = on receive) contains a lot of blank space which makes it hard to read and fill out. I think Owen(?) fixed this for creating orders (AcqCreateItem = on order), but can't find the bug right now.