Summary: | All instances of GetMemberDetails are unnecessary in C4::Circulation | ||
---|---|---|---|
Product: | Koha | Reporter: | Ian Walls <koha.sekjal> |
Component: | Architecture, internals, and plumbing | Assignee: | Ian Walls <koha.sekjal> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | blocker | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, nengard |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 7058 | ||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 7060: GetMemberDetails unnecessary in C4::Circulation Followup Patch |
Description
Ian Walls
2011-10-18 23:50:54 UTC
Created attachment 5969 [details] [review] Proposed patch Replaces all instances of GetMemberDetails in C4/Circulation.pm with GetMember, for efficiency. Test plan: 1. Check out a material 2. Renew a material 3. Return a material all three steps should return error free Created attachment 5996 [details] [review] [SIGNED-OFF] Bug 7060: GetMemberDetails unnecessary in C4::Circulation Replaces all instances of GetMemberDetails with the more efficient GetMember. Since no hash values other than the borrowers table's fields are used in this module, the transition is safe. To test: 1. Checkout a material; the page should load without error 2. Renew a material: the page should load without error 3. Return a material: the page should load without error The above test plan invokes all the subroutines affected by this patch; any call to an undefined value in a hashref should give a warning Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Marking Passed QA, RM please verify Pushed, please test I made a mistake. $borrower->{flags} are used by AddReturn in circ/returns.pl. GetMemberDetails must be used, otherwise returns break. working on fix now... Created attachment 6017 [details] [review] Followup Patch Restores GetMemberDetails usage in AddReturn; since that subroutine returned the borrower object, it was a mistake to change to GetMember, since key things like flags are not returned in that hashref. Follow up pushed |