Summary: | New Tag on results display missing results_summary class, causing display inconsistency | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <wizzyrea> |
Component: | OPAC | Assignee: | Liz Rea <wizzyrea> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | m.de.rooy, magnus, paul.poulain, wizzyrea |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 7084 - Adding results_summary class to New Tag to correct display inconsistency
Bug 7084 - Adding results_summary class to New Tag to correct display inconsistency Bug 7084 - Re-arranging results_summary for tags so that it applies where it is supposed to Bug 7084 - Re-arranging results_summary for tags so that it applies where it is supposed to |
Description
Liz Rea
2011-10-24 18:32:21 UTC
Created attachment 6042 [details] [review] Bug 7084 - Adding results_summary class to New Tag to correct display inconsistency To test: Verify that New Tag text is the same size as all of the other surrounding text. Verify that it is consistent with results that have tags. See screenshot for what it looked like before: http://screencast.com/t/hnt15kpS7SH9 Notice that the Add button and New tag text were slightly larger than the similar constructions for results with existing tags. This patch should fix that. oops, I made a mistake... proper patch incoming. Created attachment 6043 [details] [review] Bug 7084 - Adding results_summary class to New Tag to correct display inconsistency To test: Verify that New Tag text is the same size as all of the other surrounding text. Verify that it is consistent with results that have tags. See screenshot for what it looked like before: http://screencast.com/t/hnt15kpS7SH9 Notice that the Add button and New tag text were slightly larger than the similar constructions for results with existing tags. This patch should fix that. Comment on attachment 6043 [details] [review] Bug 7084 - Adding results_summary class to New Tag to correct display inconsistency sheesh. Not my day. Created attachment 6046 [details] [review] Bug 7084 - Re-arranging results_summary for tags so that it applies where it is supposed to To test: Verify that New Tag text is the same size as all of the other surrounding text. Verify that it is consistent in size with results that have existing tags. See screenshot for what it looked like before: http://screencast.com/t/hnt15kpS7SH9 Notice that the Add button and New tag text were slightly larger than the similar constructions for results with existing tags. This patch should fix that. Created attachment 6057 [details] [review] Bug 7084 - Re-arranging results_summary for tags so that it applies where it is supposed to To test: Verify that New Tag text is the same size as all of the other surrounding text. Verify that it is consistent in size with results that have existing tags. See screenshot for what it looked like before: http://screencast.com/t/hnt15kpS7SH9 Notice that the Add button and New tag text were slightly larger than the similar constructions for results with existing tags. This patch should fix that. Signed-off-by: Magnus Enger <magnus@enger.priv.no> I made sure I had a results list with on record with tags and one without. Before applying the patch the "New tag" text and "Add" button were inconsistent for the two records, after applying it they look the same. Nice! Sorry, forgot to change the subject line of the signed off patch. lol thanks for signing off on this Magnus. Seriously, what a Monday. :) QA: Very small template change. Marking it as Passed QA. Applies with one whitespace warning. patch pushed, please test Included in 3.6 prior to 3.6.5. |