Summary: | Placeholders for suggestion table in suggestion related mails broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Ian Walls <koha.sekjal> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | critical | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | koha.sekjal, nengard, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 4211 | ||
Attachments: |
Proposed Patch
[SIGNED-OFF] Bug 7093: placeholds for suggestion table not working in notices |
Description
Katrin Fischer
2011-10-26 15:15:12 UTC
*** Bug 7212 has been marked as a duplicate of this bug. *** Created attachment 6639 [details] [review] Proposed Patch In parseletter_sth, the suggestions table was defined twice. The first time (which is the only definition to get called, as it matches first then exists), defined the primary search keys as borrowernumber and biblionumber. This is incorrect; the only usage of the suggestions table tokens is with suggestionid as the key. This is defined further down the if/then chain. This patch removes the erroneous sth query definition. To test: 1. Place a suggestion with a patron account with a configured email you can access 2. Approve or reject it 3. Verify the message you receive contains suggestion tokens (like title, author and reason) Created attachment 6657 [details] [review] [SIGNED-OFF] Bug 7093: placeholds for suggestion table not working in notices In parseletter_sth, the suggestions table was defined twice. The first time (which is the only definition to get called, as it matches first then exists), defined the primary search keys as borrowernumber and biblionumber. This is incorrect; the only usage of the suggestions table tokens is with suggestionid as the key. This is defined further down the if/then chain. This patch removes the erroneous sth query definition. To test: 1. Place a suggestion with a patron account with a configured email you can access 2. Approve or reject it 3. Verify the message you receive contains suggestion tokens (like title, author and reason) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Suggestion mails for accepted, rejected and ordered look good now. I couldn't test the suggestion mail AVAILABLE (bug 7096), but assuming this would work too. Assigning to Marcel for QA, since I wrote QA comment: small patch, obvious bug, passed QA patch pushed, please test Included in 3.6 prior to 3.6.5. |