Summary: | Item form when ordering in batch from staged marc has lots of white space for hidden fields | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | m.de.rooy, magnus, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
URL: | cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=3&basketno=8&booksellerid=4 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
screenshot
Bug 7116: White space on item form for bulk ordering from staged file Bug 7116: White space on item form for bulk ordering from staged file |
Created attachment 6117 [details] [review] Bug 7116: White space on item form for bulk ordering from staged file Same fix that was done for normal order page and receive page. Moving the style element for hiding the subfield into the li tag. AcqCreateItem = on order To recreate: 1) stage a marc file with 1 - many records 2) make sure you have an acq framework with hidden fields in 952 3) create new basket 4) order from your marc file 5) check item form below the record list for white space Created attachment 6205 [details] [review] Bug 7116: White space on item form for bulk ordering from staged file Same fix that was done for normal order page and receive page. Moving the style element for hiding the subfield into the li tag. AcqCreateItem = on order To recreate: 1) stage a marc file with 1 - many records 2) make sure you have an acq framework with hidden fields in 952 3) create new basket 4) order from your marc file 5) check item form below the record list for white space Signed-off-by: Magnus Enger <magnus@enger.priv.no> Followed the steps outlined by Katrin above. Before the patch there are gaping holes left by the hidden fields. After the patch the holes are gone. Thanks for the great test plan! QA: Small change in template only. Looks good. Changed from enhancement to minor bug fix. Updating patch status. patch pushed, please test |
Created attachment 6116 [details] screenshot AcqCreateItem = on order To recreate: 1) stage a marc file with 1 - many records 2) make sure you have an acq framework with hidden fields in 952 3) create new basket 4) order from your marc file 5) check item form below the record list for white space