Summary: | Any and empty entries in pull downs for suggestion filters | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | trivial | ||
Priority: | P1 - high | CC: | chris, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/suggestion/suggestion.pl?displayby=managedby&branchcode=# | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Bug 7118: Remove 'any' from pull downs in acquisitions |
Description
Katrin Fischer
2011-10-31 00:33:19 UTC
Created attachment 6120 [details] [review] Bug 7118: Remove 'any' from pull downs in acquisitions The filters on the suggestion page show 'Any' and an empty entry for the filters 'Suggested by', 'Accepted by' and 'Managed by'. Both do the same. It should only be 'Any' or an empty entry, but not both. To test: - check 'Any' is gone, but empty entry still shows - check you can still unset filters 'managed by', 'suggested by' and 'accepted by' Managed by and suggested by work, but I have no blank entry for Suggested by. Hi Chris, did you mean 'suggested by'? My list looks like this: <li><label for="suggestedby"> Suggested By:</label> <select id="suggestedby" name="suggestedby"> <option value="">Any</option> <option value="0"></option> <option value="2">Katrin, Fischer</option> So my blank entry came from the 0 value, but there is indeed no value="" line. Investigating... Ok, I see now what's going on here: The empty line shows when you have at least one suggestion, where the value for the column is null. For 'suggested by' this should never happen, so there is no empty line. Not sure how I managed to do that - might be a bug or from testing something else. The 'Any' lines are actually needed. So the solution to the confusing list is invalid. Any and the empty lines have both value="". So both settings will search for all entries and there is currently no way to search for unmanaged or unaccepted entries. Leaving the bug open. Looks good now, please reopen if I am wrong. |