Summary: | in addbiblio, make save button floating to have it on always on screen | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Cataloging | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, duncan, koha.sekjal, paul.poulain, wizzyrea |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 2710 | ||
Attachments: |
Proposed fix
Bug 7135: Save button options [Signed Off] Fix for Bug 7135: Save button options Follow-up fix Signed off follow up fix for patch. |
Description
Nicole C. Engard
2011-11-01 20:29:48 UTC
Created attachment 6167 [details] [review] Proposed fix This patch adds a jQuery plugin which will cause an element to remain "fixed" at the top of the screen if it would otherwise scroll up out of view. I submit this patch for TESTING ONLY because the plugin was not posted with explicit licensing. I'm waiting to hear back from the author. How it should look: http://screencast.com/t/0gBcTT6OKQ Tested successfully so far in: FF7 / Win7 Chrome 15 / Win7 IE8 / Win7 Opera 11 / Win7 Safari 5 / Win7 Chrome 14 / Ubuntu 11.10 Firefox 7 / Ubuntu 11.10 Not exactly a license, but the author responds "This plugin is as free as fresh air. Feel free to use it anywhere." I think that is pretty close to the WTFPL http://en.wikipedia.org/wiki/WTFPL :) Signing off, works in 11.10 Chromium 17 as well Created attachment 6626 [details] [review] Bug 7135: Save button options This patch adds a jQuery plugin which will cause an element to remain "fixed" at the top of the screen if it would otherwise scroll up out of view. I submit this patch for TESTING ONLY because the plugin was not posted with explicit licensing. I'm waiting to hear back from the author. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 6627 [details] [review] [Signed Off] Fix for Bug 7135: Save button options This patch adds a jQuery plugin which will cause an element to remain "fixed" at the top of the screen if it would otherwise scroll up out of view. I submit this patch for TESTING ONLY because the plugin was not posted with explicit licensing. I'm waiting to hear back from the author. Signed-off-by: Liz Rea <wizzyrea@gmail.com> I tested this on Chrome OSX saving works changing framework works scrolling works, obviously. tabbing through the records works z39 button works as expected And Firefox 8.0.1 (In reply to comment #7) > Created attachment 6627 [details] [review] > [Signed Off] Fix for Bug 7135: Save button options > > This patch adds a jQuery plugin which will cause > an element to remain "fixed" at the top of the > screen if it would otherwise scroll up out of > view. > > I submit this patch for TESTING ONLY because > the plugin was not posted with explicit licensing. > I'm waiting to hear back from the author. > > Signed-off-by: Liz Rea <wizzyrea@gmail.com> > I tested this on Chrome OSX > saving works > changing framework works > scrolling works, obviously. > tabbing through the records works > z39 button works as expected QA comment: * tested, works fine * license question solved, i've updated the patch comment to reflect that passed QA patch pushed, please test chris_n = maybe worth for 3.6, but beware it changes addbiblio behaviour, that can surprise users ! oups... failed QA detected just before pushing the patch !!! * addbiblio * open the "More" menu => the menus are BELOW the save button, making Reports & Serial unreachable ! Created attachment 6760 [details] [review] Follow-up fix Follow-up fix corrects z-index of toolbar so that "More" menu is not hidden behind it. Created attachment 6761 [details] [review] Signed off follow up fix for patch. follow-up patch pushed, thanks for the quick fix ! This fix was included in the 3.6.x branch prior to 3.6.4. |