Summary: | Log circulation messags | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Reports | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | brendan, koha.sekjal, m.de.rooy, nengard, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 7139 : Log addition and deletion of circulation messages
Signed-Off Bug 7139 : Log addition and deletion of circulation messages Signed patch (text revised) |
Description
Chris Cormack
2011-11-02 01:19:48 UTC
Created attachment 6138 [details] [review] Bug 7139 : Log addition and deletion of circulation messages Created attachment 6182 [details] [review] Signed-Off Bug 7139 : Log addition and deletion of circulation messages Signed-Off Good clean code, but the second param passed to logaction (actionname) is traditionally in all caps, not regular text (and never with spaces). This is probably safe, but for consistency, I'd prefer: ADDMESSAGE and DELMESSAGE. Community feedback: am I been too much of a stickler here? Created attachment 6714 [details] [review] Signed patch (text revised) QA comment: * problem pointed by ian addressed by Marcel revised patch, * works well, * perlcritic fails, but it was failing before this patch passed QA patch pushed, please test Included in 3.6 prior to 3.6.5. |