Summary: | stage_biblios_file.pl is missing options for encodings, wrongly passing the MARC flavour instead | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | MARC Bibliographic record staging/import | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | major | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | jcamins, paul.poulain, ulrich.kleiber |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 7250: stage_biblios_file.pl is missing options for encoding
Successfully tested with default encoding utf8. test records |
Description
Katrin Fischer
2011-11-21 06:41:38 UTC
Created attachment 6361 [details] [review] Bug 7250: stage_biblios_file.pl is missing options for encoding - adds command line options for encoding, defaulting to utf8 - options match options availablen in the stage marc records form of the staff interface - activates warnings - adds copyright statement To test: Import records with diacritics using the stage_biblios_file.pl Records can be imported into the catalog using the staff interface or the commit_biblios_file.pl script. Created attachment 6374 [details] [review] Successfully tested with default encoding utf8. Fixes an issue with the usage of BatchStageMarcRecords, as well as adds copyright statements, documentation, and cleans up spacing. Marking as Passed QA. I can't reproduce the problem or find a difference with and without the patch. As the patch has been tested & signed-off by the same company, I really want to double check. Katrin/Ulrich = could you attach an example iso2709 file please ? (note i'm UNIMARC, maybe the problem is MARC21 related) Created attachment 6390 [details]
test records
Without the patch the sub is called with wrong parameters - marcflavour instead of encoding. Without patch the umlauts in the attached marc file should be broken after import.
stage_biblios_file.pl is to be run from command line. Documentation was updated to reflect the change.
I can confirm both the bug and the patch, at least for my test data. Good catch, Katrin! patch pushed please test NOTE: just in case you miss the information like I did: it worked through the staff interface, this fix is just for staging records through the command line script (misc/stage_biblios_file.pl) Test plan: ./stage_biblios_file.pl --encoding ISO_5426 --file ../temp/panier.iso2709 --comment command_line ... staging MARC records -- please wait ... finished staging MARC records MARC record staging report ------------------------------------ Input file: ../temp/panier.iso2709 Number of input bibs: 4 Number of valid bibs: 4 Number of invalid bibs: 0 Incoming bibs not matched against existing bibs (--match-bibs option not supplied) No items parsed (--add-items option not supplied) => checked that diacritics were OK on the staff interface, they were |