Summary: | Show a count of items pending approval on staff client home and tools pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, paul.poulain, viktor.sarge, wizzyrea |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 7875 | ||
Bug Blocks: | |||
Attachments: |
Proposed fix
[Signed Off] Bug 7259 - Show a count of items pending approval on staff client home and tools pages Follow-up fix |
Description
Owen Leonard
2011-11-23 19:24:35 UTC
Created attachment 6383 [details] [review] Proposed fix Created attachment 6384 [details] [review] [Signed Off] Bug 7259 - Show a count of items pending approval on staff client home and tools pages This patch adds count indicators on the staff client home page and the tools page for the number of items pending approval. On the home page this includes suggestions, comments, and tags. On the tools page a count of pending comments and tags is shown. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Counts appear for all types of actionable items listed, all are clickable through to the proper place. Nice work! *** Bug 6451 has been marked as a duplicate of this bug. *** QA comments: From the code, it appears that if a user can moderate tags, but not comments (or vice versa), they'll see both counts on the intranet-main page, rather than just the type they can moderate. Changes input params for numberofreviews subroutine. While all usages of this subroutine are updated (just one), I would recommend adding a default value of 1 to the $status variable, so any code that calls the subroutine will continue to function as before. Introduces 3 new dependencies into intranet-main. Not sure there is anything that can be done about that, but it will increase page load time slightly (more just a note here than an actual QA request) While I cannot envision a situation where folks WOULDN'T want to know about these pending items, should the display of these counts be controlled by a system preference? This would prevent sudden, surprising change, which can really freak folks out. Created attachment 6637 [details] [review] Follow-up fix This follow-up, to be applied on top of the first, does the following: - Corrects permissions checks on the home page - Adds default parameter (1) to numberofreviews subroutine Owen, Thank you for providing those fixes. I'm happy to sign off on your followup, and pass both patches through QA. Patch pushed, please test This was incorporated into 3.6.x prior to 3.6.4. |