Bug 7262

Summary: No calendar present in holidays module when there are quotes in title or description
Product: Koha Reporter: Juan Romay Sieira <juan.sieira>
Component: HolidaysAssignee: Juan Romay Sieira <juan.sieira>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris, paul.poulain
Version: 3.6   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Path to solve it
Bug 7262 - No calendar present in holidays module when there are quotes in title or description

Description Juan Romay Sieira 2011-11-24 16:59:57 UTC
Using the holidays module, if a user inserts quotes under title or description of a holiday, the calendar does not appear, because of javascript errors.
Comment 1 Katrin Fischer 2011-11-24 17:03:13 UTC
I can confirm this bug.
Comment 2 Juan Romay Sieira 2011-11-24 17:04:36 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2011-11-25 06:13:56 UTC
Hi Juan, plz remember to set Importance to 'Patch sent' and Patch Status to 'Needs Signoff' after attaching your patch :)
Comment 4 Chris Cormack 2011-12-01 19:20:32 UTC
Created attachment 6493 [details] [review]
Bug 7262 - No calendar present in holidays module when there are quotes in title or description

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nice patch, making use of the Template::Toolkit filters
Comment 5 Paul Poulain 2011-12-14 16:56:30 UTC
QA comment: works fine, don't break templates:
$ prove xt/author/valid-templates.t 
xt/author/valid-templates.t .. ok     
All tests successful.

prove xt/author/translatable-templates.t
xt/author/translatable-templates.t .. ok   
All tests successful.

passed QA

patch pushed, please test
Comment 6 Katrin Fischer 2012-04-14 13:59:03 UTC
Tested ok in master.