Summary: | overdue.pl : filter on flags "debarred" "suspended" and "gonenoaddress" not working | ||
---|---|---|---|
Product: | Koha | Reporter: | Adrien SAURAT <adrien.saurat> |
Component: | Circulation | Assignee: | Adrien SAURAT <adrien.saurat> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
patch
patch #2 proposed patch Bug 7266: flags debarred, suspended, gonenoaddress in overdue |
Description
Adrien SAURAT
2011-11-25 10:33:03 UTC
Created attachment 6407 [details] [review] patch Adrian + elsif ( $borflagsfilter eq 'lost') { + $strsth .= " AND borrowers.debarred <> 0"; + } Shouldn't that be checking lost not debarred? Created attachment 6519 [details] [review] patch #2 Corrected the "lost" case which was checking the "debarred" field. The first patch does not apply for me. Tried with git bz apply and git am -i3u. Applying: Bug 7266: filter on "Patron flags" in overdue.pl error: patch failed: circ/overdue.pl:266 error: circ/overdue.pl: patch does not apply Patch failed at 0001 Bug 7266: filter on "Patron flags" in overdue.pl If you can rebase this against current master, can you please also squash the two patches together? Thanks. Created attachment 6884 [details] [review] proposed patch New patch ready. Created attachment 6886 [details] [review] Bug 7266: flags debarred, suspended, gonenoaddress in overdue This patch makes these flags functionnal. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> QA comment: small patch, perlcritic compliant, passed QA. Won't work for 3.6, as it relies on fine in days There have been no further reports of problems so I am marking this bug resolved. |