Bug 7271

Summary:	Revert getitems default sort to homebranch instead of holding branch
Product:	Koha	Reporter:	Liz Rea <wizzyrea>
Component:	Staff interface	Assignee:	Liz Rea <wizzyrea>
Status:	CLOSED FIXED	QA Contact:	Ian Walls <koha.sekjal>
Severity:	normal
Priority:	P3	CC:	chris, gmcharlt, nengard, paul.poulain, wizzyrea
Version:	3.6
Hardware:	All
OS:	All
See Also:	http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 7271 - change sort in items.pm to sort by home library instead of holding branch Bug 7271 - change sort in items.pm to sort by home library instead of holding branch

Description Liz Rea 2011-11-28 18:01:40 UTC

The fix to bug 6600 changed the default sort order of the items display - it used to order by home branch and now it orders by holding branch, a source of confusion for our libraries.

There are a couple of ways to fix this problem -

1. tablesort items and set the default sort
2. change the default ORDER BY in Items.pm

I have a patch for 2, but am worried about ramifications of that change. 1 might cause problems for bibs with many items.

What do you think, which is better?

Comment 1 Liz Rea 2011-11-28 22:39:58 UTC Comment hidden (obsolete)

Created attachment 6450 [details] [review]
Bug 7271 - change sort in items.pm to sort by home library instead of holding branch

Comment 2 Liz Rea 2011-11-28 22:44:02 UTC

As Ian reports in but 6600 - 

GetItemsInfo is used in the following scripts:
./C4/XSLT.pm
./C4/Reserves.pm
./reports/reservereport.pl
./labels/label-item-search.pl
./virtualshelves/sendshelf.pl
./catalogue/moredetail.pl
./catalogue/detailprint.pl
./catalogue/detail.pl
./basket/basket.pl
./basket/sendbasket.pl
./serials/routing-preview.pl
./misc/migration_tools/rebuild_zebra.pl
./opac/opac-reserve.pl
./opac/opac-sendbasket.pl
./opac/opac-detail.pl
./opac/opac-ISBDdetail.pl
./opac/opac-sendshelf.pl

So it seems reasonable that one should check all of these places during testing - I admit that I have not *yet* made it through this whole list, but I wanted to get the patch out for further review and/or "that's a terrible idea don't do that!"

This does fix a micro-regression in that the sorting of items was different/confusing after the patch for bug 6600, and also preserves the functionality of 6600. I am sure that QA will have an opinion on this one.

Comment 3 Nicole C. Engard 2011-12-13 18:19:18 UTC

Isn't this the kind of thing that should be a preference? Some library asked for it to sort the way it does, so changing it on them would probably upset them.  Just a thought.

Nicole

Comment 4 Liz Rea 2011-12-13 20:20:50 UTC

No, actually the sort here isn't intentional - this is a regression.

Comment 5 Liz Rea 2011-12-13 20:21:46 UTC

that is to say - it puts it back the way it was before the patch that changed the sort - the change to the sort was an unintended side effect of another patch.

Comment 6 Chris Cormack 2012-03-03 07:35:58 UTC

Created attachment 7998 [details] [review]
Bug 7271 - change sort in items.pm to sort by home library instead of holding branch

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Comment 7 Chris Cormack 2012-03-03 07:36:40 UTC

Fixes a regression.

Comment 8 Ian Walls 2012-03-05 18:51:06 UTC

JOINS with 'branches' table twice, once for home and once for holding, and elegantly distinguishes the two.  Marking as Passed QA.

Comment 9 Jared Camins-Esakov 2012-05-09 16:59:47 UTC

This bug will be included in the Koha 3.6.5 release.