Summary: | ILSDI HoldItem service does't set the itemnumber in reserves table | ||
---|---|---|---|
Product: | Koha | Reporter: | Alex Arnaud <alex.arnaud> |
Component: | Architecture, internals, and plumbing | Assignee: | Alex Arnaud <alex.arnaud> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | normal | ||
Priority: | P3 | CC: | chris, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Bug 7299 passe itemnumber in ILSDI holditem service Bug 7299 pass itemnumber in ILSDI holditem service |
Description
Alex Arnaud
2011-12-02 09:49:08 UTC
Created attachment 6521 [details] [review] Proposed patch Hmmm, this now also passes in the biblionumber as biblioitemnumber ... which may not always be the same thing. Luckily because it is constraint 'a' it isn't used. But I wonder if we should remove it so it isn't confusing in future? Created attachment 10005 [details] [review] Bug 7299 passe itemnumber in ILSDI holditem service This new patch does 2 things: - Remove biblioitemnumber - Add full namespace for call to CanItemBeReserved function Created attachment 10447 [details] [review] Bug 7299 pass itemnumber in ILSDI holditem service Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> QA comment: I think you could have removed the # $branch, $borrowernumber, $biblionumber, $constraint, $bibitems, $priority, $notes, $title, $checkitem, $found instead of fixing it, but that's not worth failing QA ;-) Small patch. Also add C4::Reserves:: probably needed because of nested packages. |