|
Description
claire.hernandez@biblibre.com
2011-12-02 09:52:23 UTC
Created attachment 7687 [details] [review] Bug 7302 Export basketgroup as CSV Adds new action export for basketgroup. This action is available only if your basketgroup is closed. This export generates a csv file with order informations. Everything is ok but the encoding. Accented characters does not appear correctly in the csv file Created attachment 8381 [details] [review] Bug 7302 Export basketgroup as CSV This patch modify the export as csv (basket and basketgroup, please test both). Encoding is now correct. Export is ok with correct encoding (basket and basket group) but in basket group file, some informations are missing : Client number (Account number in bookseller exists) ; Basket group; delivery place ; Basket group billing ; place; Basket delivery place;Basket billing place. Columns are empty but the information are in the basketgroup. Created attachment 8400 [details] [review] Bug 7302 Export basketgroup as CSV This patch fix the "client number" (accountnumber in DB). But fields billingplace and deliveryplace are introduced by Bug 5356. Its can not be tested now. Please test Bug 5356 with this patch. They are dependants... You can test it with a sandbox try to apply on a Lyon3 branch rebase on the git-community/master. Applying: Bug 7302: Export basketgroup as CSV error: patch failed: C4/Acquisition.pm:42 error: C4/Acquisition.pm: patch does not apply Patch failed at 0001 Bug 7302: Export basketgroup as CSV When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-7302-Export-basketgroup-as-CSV-6yG1Rc.patch Created attachment 8530 [details] [review] Bug 7302 Export basketgroup as CSV Rebased patch. It's normal you see nothing in the delivery* and billing* fields without the Bug 5356 Created attachment 8944 [details] [review] Bug 7302 Export basketgroup as CSV Rebased patch Applying: Bug 7302: Export basketgroup as CSV error: patch failed: C4/Output.pm:41 error: C4/Output.pm: patch does not apply Patch failed at 0001 Bug 7302: Export basketgroup as CSV Created attachment 9227 [details] [review] Bug 7302 Export basketgroup as CSV Rebased patch Created attachment 9974 [details] [review] Bug 7302 Export basketgroup as CSV rebased patch Testing this without 5356 - billing address fields don't show up as expected, but feature works nicely. Will provide a follow up changing the column name from "Client number" to "Account number" to match description of the field in Koha. Patch depends on 5356 so testing not yet complete. Waiting for rebase of 5356. Created attachment 10150 [details] [review] Bug 7302: Followup: rename "Client number" column with "Account number" Created attachment 10336 [details] [review] [SIGNED-OFF] Bug 7302: Export basketgroup as CSV Adds new action export for basketgroup. This action is available only if your basketgroup is closed. This export generates a csv file with order informations. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested together with bug 5356. Created attachment 10337 [details] [review] [SIGNED-OFF] Bug 7302: Followup: rename "Client number" column with "Account number" Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> (In reply to comment #17) > Created attachment 10337 [details] [review] > [SIGNED-OFF] Bug 7302: Followup: rename "Client number" column with "Account > number" > > Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> passing QA on both(2) patches... $ koha-qa.pl -c 2 - 6937f34 Bug 7302: Export basketgroup as CSV koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/basketgroup.tt C4/Acquisition.pm C4/Output.pm acqui/basket.pl acqui/basketgroup.pl koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/basket.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/basketgroup.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/vaild-template.t tests... OK Small additionnal QA comment: the <export as CSV> button had no header. I've removed a </td></td> to have it in the same column as Reopen and Print buttons Patch pushed |