Bug 7323

Summary: Javascript error when editing list
Product: Koha Reporter: Owen Leonard <oleonard>
Component: ListsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: minor    
Priority: PATCH-Sent (DO NOT USE) CC: chris, paul.poulain
Version: 3.6   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/virtualshelves/shelves.pl?shelfnumber=XX&op=modif
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed fix
Bug 7323 - Javascript error when editing list

Description Owen Leonard 2011-12-06 16:42:48 UTC
Firebug reports an error when editing a list in the staff client:

f.addshelf is undefined
Line 186
Comment 1 Owen Leonard 2011-12-06 16:45:55 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-12-12 09:03:46 UTC
Created attachment 6718 [details] [review]
Bug 7323 - Javascript error when editing list

Correcting check for empty shelf name to prevent
javascript error.

Also correcting unescaped ampersand.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 3 Paul Poulain 2011-12-15 15:58:51 UTC
QA comment : tiny patch, fixes the problem

passed QA

patch pushed, please test
Comment 4 Jared Camins-Esakov 2012-05-23 12:51:54 UTC
This fix was included in the 3.6.x branch prior to 3.6.4.