Summary: | Improve 'No address stored' and similar messages in patron account | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | trivial | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
screenshot
Bug 7334: Improve 'no address stored' and similar messages in patron account Signed-off patch |
Created attachment 6659 [details] [review] Bug 7334: Improve 'no address stored' and similar messages in patron account - 'no address stored' is now only displayed when first and second line of the address are empty - added id's to all 3 possible messages so people can change or hide them To test: 1) Check 'no address stored' shows only up when address fields are both empty 2) Check address is still correctly displayed Note: make sure you check the 'checkouts' and other tabs, because there are 2 different include files used here. Created attachment 6662 [details] [review] Signed-off patch Bug 7334: Improve 'no address stored' and similar messages in patron account - 'no address stored' is now only displayed when first and second line of the address are empty - added id's to all 3 possible messages so people can change or hide them To test: 1) Check 'no address stored' shows only up when address fields are both empty 2) Check address is still correctly displayed Note: make sure you check the 'checkouts' and other tabs, because there are 2 different include files used here. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm the bug and the solution. Text messages identification for customization with JavaScript is a plus. QA comment: small patch related to templates, works prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok passed QA patch pushed, please test Included in 3.6 prior to 3.6.5. |
Created attachment 6658 [details] screenshot The 'no address stored' message above the left menu in the patron account shows up, when the first address field is empty. It would make more sense to check for first and second address line to be empty, before showing the message.