Summary: | "Debarred Until" display in the opac tells patrons they are debarred until the year 9999 | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <wizzyrea> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | paul.poulain, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed fix
[Signed Off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999 Bug 7337 - Followup - Correcting instances of "debar" that crept back in. Revised fix [Signed off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999 |
Description
Liz Rea
2011-12-08 14:33:52 UTC
Created attachment 6667 [details] [review] Proposed fix This patch copies the debarred handling method from circulation.pl for use on opac-user.pl so that debarred dates and comments can be handled properly. I have slightly reworded the message in the OPAC and on circulation.pl to make the display of the debarred comment a little clearer. Created attachment 6668 [details] [review] [Signed Off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999 This patch copies the debarred handling method from circulation.pl for use on opac-user.pl so that debarred dates and comments can be handled properly. I have slightly reworded the message in the OPAC and on circulation.pl to make the display of the debarred comment a little clearer. Signed-off-by: Liz Rea <wizzyrea@gmail.com> I like this change, nice fix for the bug. Thanks! Created attachment 6671 [details] [review] Bug 7337 - Followup - Correcting instances of "debar" that crept back in. To test: Restrict one of your patrons - Make sure that on memberentrygen.tt (Edit Patron) the radio button label says "Restricted" Make sure that on moremember.tt (Patron detail) the button to lift debarment says "Restricted" Comment on attachment 6668 [details] [review] [Signed Off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999 Found a problem with the template renewing books for debarred patrons. Owen says he'll revise and I'll provide a new signoff. Created attachment 6673 [details] [review] Revised fix Revision adds missing handling of debarred status with regard to renewal operations. Renew links and buttons were not being hidden from debarred users. Created attachment 6674 [details] [review] [Signed off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999 This patch copies the debarred handling method from circulation.pl for use on opac-user.pl so that debarred dates and comments can be handled properly. I have slightly reworded the message in the OPAC and on circulation.pl to make the display of the debarred comment a little clearer. Revision adds missing handling of debarred status with regard to renewal operations. Renew links and buttons were not being hidden from debarred users. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Renewal buttons are gone, message looks good. liz@koha-deb:~/kohaclone$ prove xt xt/permissions.t .. ok xt/tt_valid.t ..... ok All tests successful. Files=2, Tests=27, 9 wallclock secs ( 0.05 usr 0.01 sys + 8.28 cusr 0.08 csys = 8.42 CPU) Result: PASS Both attached patches are template-level only (with some small bit of additional logic in opac/opac-user.pl to pass the right variables). Easy to read, and removes the display of system-placeholder dates like 9999-12-31. Marking Passed QA patch pushed, please test There have been no further reports of problems so I am marking this bug resolved. |