Summary: | aqbudgets statistics doesn't work when using Authorized values on sort1_authcat or sort2_authcat | ||
---|---|---|---|
Product: | Koha | Reporter: | Alex Arnaud <alex.arnaud> |
Component: | Acquisitions | Assignee: | Alex Arnaud <alex.arnaud> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P3 | CC: | chris, francois.charbonnier, m.de.rooy, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Creating new order
Changing fund in new order Proposed patch Bug 7342: Follow up fixing FSF address and adding use warnings [SIGNED-OFF] bug 7342 - neworderempty: Fix empty values in statistic 1 and 2 dropboxes [SIGNED-OFF] Bug 7342: Follow up fixing FSF address and adding use warnings Replacement patch Signed replacement patch |
Description
Alex Arnaud
2011-12-09 08:35:28 UTC
Created attachment 6691 [details]
Creating new order
Created attachment 6692 [details]
Changing fund in new order
patch is coming soon Created attachment 6693 [details] [review] Proposed patch Hi Alex A little thing is this patch, that will cause the tests to fail, is the address for the FSF is wrong It is # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. (check mainpage.pl in master). I wont fail QA it for that, but it will need either a follow up or Paul to fix when he pushes it. Created attachment 6696 [details] [review] Bug 7342: Follow up fixing FSF address and adding use warnings Created attachment 6753 [details] [review] [SIGNED-OFF] bug 7342 - neworderempty: Fix empty values in statistic 1 and 2 dropboxes Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com> Created attachment 6754 [details] [review] [SIGNED-OFF] Bug 7342: Follow up fixing FSF address and adding use warnings Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com> Test I did : 1/ define authorised values categories that you will use to set up funds. 2/ then set up (at least) 2 funds and choose the categories define above within "Statistic 1 done on:" and "Statistic 2 done on:" fields 3/ create new basket and place one order 4/ when placing the order : choose the funds you created and check that the authorised values within "statistic 1" and "statistic 2" change correctly. 5/ save the orderline and click on "modify" to make sure that the chosen values got recorded 6/ check the database. go to mysql and try : SELECT sort1, sort2 FROM aqorders WHERE ordernumber='XXX'; 7/ you will have the values you just entered when placing your order. Just a (dumb) question: Patch creates a new script, but where does Koha call it? Couldn't see that just browsing through.. Still waiting for an answer on earlier comment. Hi Marcel, This patch RE-creates a script that probably had been deleted by mistake. This script is used by "fetchSortDropbox()" javascript function (in tmpl_dir/prog/en/js/acq.js) which is called by an onchange event on budget_id select in neworderempty.tt. It's an ajax call in order to fill correctly the 'statistic 1' and 'statistic 2' comboboxes. Hi ALex, Thanks for responding. Just a few minor points: I see a POD line with only title of the script ;) See a FIXME after template name. See a new commented line for #my $dropbox_values; See a 1; at the end of the script (but this is not a module !!) Could you still adjust ? Created attachment 7253 [details] [review] Replacement patch Marcel, here is the new patch. This is not a follow up but a replacement patch. Created attachment 7289 [details] [review] Signed replacement patch Tested. Comments have been incorporated. Marking as Passed QA. This fix was included in the 3.6.x branch prior to 3.6.4. |