Bug 7354

Summary: Can't edit local use system preferences
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: System AdministrationAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: critical    
Priority: P5 - low CC: chris, gmcharlt, m.de.rooy, paul.poulain
Version: 3.6   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/admin/systempreferences.pl
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Add local use system preference
Saved local use system preference
Edit local use system preference
Bug 7354: Can't edit local use system preferences
Bug 7354: Can't edit local use system preferences

Description Katrin Fischer 2011-12-14 06:39:08 UTC
Created attachment 6768 [details]
Add local use system preference

At the moment it's not possible to edit local use system preferences. I will attach a set of screenshots to show the problem.

To reproduce:
1) Create a new local use system preference
2) Verify it shows up in the tab of local use preferences
3) Try to edit the system preference

Problem: All fields are shown as empty.
- explanation
- variable type
- variable options

Saving the system preference like this will delete those fields from the database.
Comment 1 Katrin Fischer 2011-12-14 06:39:28 UTC
Created attachment 6769 [details]
Saved local use system preference
Comment 2 Katrin Fischer 2011-12-14 06:39:49 UTC
Created attachment 6770 [details]
Edit local use system preference
Comment 3 Katrin Fischer 2012-04-12 07:02:16 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2012-04-12 07:35:01 UTC
Created attachment 9132 [details] [review]
Bug 7354: Can't edit local use system preferences

Fixes adding and editing of local use system preferences and redirects to correct
page after saving.

To test:
- Create a new local use system preference
- Edit an existing local use system preference from summary page
- Edit an existing local use system preference using 'Edit'
- Delete a local use system preference

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Marcel de Rooy 2012-04-16 08:28:14 UTC
QA Comment: Looks good to me. Works as advertised. No translation issues involved.
Passed QA
Comment 6 Jared Camins-Esakov 2012-05-24 00:58:53 UTC
This will be incorporated into 3.6.5.