Bug 7375

Summary:	Update minimum version of Perl to 5.10
Product:	Koha	Reporter:	Magnus Enger <magnus>
Component:	Installation and upgrade (web-based installer)	Assignee:	Magnus Enger <magnus>
Status:	CLOSED FIXED	QA Contact:	Ian Walls <koha.sekjal>
Severity:	minor
Priority:	PATCH-Sent (DO NOT USE)	CC:	chris, gmcharlt, m.de.rooy, paul.poulain
Version:	3.6
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Proposed patch Bug 7375 - Update minimum version of Perl to 5.10

Description Magnus Enger 2011-12-22 08:51:50 UTC

koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt:

52     <li>Your perl version seems to be obsolete.
53       Please upgrade to a newer version of Perl (at least Version 5.006001).</li>

This should say at least version 5.10.

How should the version number be formatted? Is a simple "5.10" enough or should it be something like "5.010001"?

Comment 1 Marcel de Rooy 2011-12-22 08:54:10 UTC

perl -v says with me:
This is perl, v5.10.0 built for x86_64-linux-thread-multi

So I would go for a simple 5.10

Comment 2 Magnus Enger 2011-12-22 09:15:55 UTC

Oops, I just assumed that the installer was actually checking for 5.10, but it seems it does not: 

62 unless ( $] >= 5.008008 ) {    # Bug 4505
63 $template->param( problems => 1, perlversion => 1, checkmodule => 0 );

I have changed the name of this bug to reflect the broader scope of this bug.

Comment 3 Magnus Enger 2011-12-22 10:00:14 UTC Comment hidden (obsolete)

Created attachment 6922 [details] [review]
Proposed patch

- Change the installer script to look for at least 5.10/5.010000
- Change the template to ask for the correct version
    
To test:
- Run through the webinstaller on 5.10 or newer and check that there are no errors.
- Ideally: Run through the webinstaller on an older version than 5.10 and check that there *is* an error, asking for 5.10 or newer.

Comment 4 Chris Cormack 2011-12-22 19:22:02 UTC

Created attachment 6926 [details] [review]
Bug 7375 - Update minimum version of Perl to 5.10

- Change the installer script to look for at least 5.10/5.010000
- Change the template to ask for the correct version

To test:
- Run through the webinstaller on 5.10 or newer and check that there are
no errors.
- Ideally: Run through the webinstaller on an older version than 5.10 and
check that there *is* an error, asking for 5.10 or newer.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Comment 5 Ian Walls 2012-01-09 20:38:38 UTC

Simple change to version numbers, one in a comparison, other in a string.  Marking Passed QA (as 5.10 is indeed the minimum version at this time)

Comment 6 Paul Poulain 2012-01-13 10:42:56 UTC

Patch pushed, please test

Comment 7 Jared Camins-Esakov 2012-05-23 12:29:48 UTC

Included in the 3.6 branch prior to 3.6.4.

Comment 8 Magnus Enger 2012-10-10 07:20:59 UTC

This has been in use for a while, without any complaints.