Summary: | invoice not showing received titles | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Acquisitions | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | normal | ||
Priority: | P3 | CC: | chris, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 929 | ||
Bug Blocks: | |||
Attachments: |
Bug 7402 : Fixing the date formatting so links to the invoice page work
[SIGNED-OFF] Bug 7402 : Fixing the date formatting so links to the invoice page work |
Description
Nicole C. Engard
2012-01-04 19:03:27 UTC
The URL after clicking the invoice number is: cgi-bin/koha/acqui/parcel.pl?invoice=4567890-9&supplierid=1&datereceived=07/27/2011 The URL that works was: /cgi-bin/koha/acqui/parcels.pl?supplierid=28 Sorry, I worded that wrong. If you click the date on the second URL I gave it shows you items you have received. The URL is: cgi-bin/koha/acqui/parcel.pl?type=intra&supplierid=1&datereceived=2011-12-15&invoice=323231 So the date format in the broken URL is probably causing problems. Hmm this could be fixed by using the new KohaDates filter which is part of bug 929 Ill get 929 rebased then will fix this. Created attachment 7041 [details] [review] Bug 7402 : Fixing the date formatting so links to the invoice page work This depends on bug 929 This depends on 929, which is passed QA so should be in master soon But to test before then, need to apply the patches from 929 then this Hm, it does not work for me. I think the problem is, that the URL needs the date in iso format - not relying on dateformat setttings. From 929: my $datereceived = C4::Dates->new( $data->{'datereceived'}, 'iso' ); Working link: http://localhost:8080/cgi-bin/koha/acqui/parcel.pl?invoice=7402&supplierid=1&datereceived=2012-01-18 Well... it certainly helps to apply the patch you want to test before testing... patch does just that and works nicely. Created attachment 7210 [details] [review] [SIGNED-OFF] Bug 7402 : Fixing the date formatting so links to the invoice page work This depends on bug 929 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Uses the new TT plugin to display the date, while using iso format to build a correct URL to the invoice page. Moves formatting of dates from perl to template, making use of new Koha Dates filter. Simple change, marking as Passed QA Works on master and patch is also in 3.6.x - marking resolved. |