Summary: | Borrower without expiry date breaks opac login | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jcamins, m.de.rooy, nikhilvr0, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Adds expiry date to admin user in patron sample data
Bug 7453: All patrons should have an expiry date Followup to check dateexpiry [SIGNED-OFF] 7453 Followup for borrower without expiry date |
Description
Katrin Fischer
2012-01-20 06:57:27 UTC
Created attachment 7252 [details] [review] Adds expiry date to admin user in patron sample data Created attachment 7358 [details] [review] Bug 7453: All patrons should have an expiry date Fixes sample data. All patrons should always have an expiry date. To test: Load sample patron data and check that all patrons have an expiry date. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> QA comment: * SQL only, no specific comment, tiny patch * tested all files Created attachment 7817 [details] [review] Followup to check dateexpiry While it should be impossible now to have a patron without expiry date, I still had one. It does not hurt to add a simple check on expiry date defined before calling delta days on null values and breaking the opac login. Trivial change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> *** Bug 7529 has been marked as a duplicate of this bug. *** Created attachment 7845 [details] [review] [SIGNED-OFF] 7453 Followup for borrower without expiry date While it should be impossible now to have a patron without expiry date, I still had one. It does not hurt to add a simple check on expiry date defined before calling delta days on null values and breaking the opac login. Trivial change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested by deleting the expirydate from my own patron record. Missing expiry date now no longer breaks the summary page in the patron account on OPAC. Simple patch adds check for existent expiry date before making use of it's values. Marking as Passed QA. This will be in the upcoming 3.6.5 release. No string changes. |