Summary: | Itemtype codes with hyphens and spaces can cause unexpected search results | ||
---|---|---|---|
Product: | Koha | Reporter: | Thatcher Rea <thatcher.rea> |
Component: | Searching | Assignee: | Galen Charlton <gmcharlt> |
Status: | NEW --- | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | dcook, koha, lisette, martin.renvoize, mathsabypro, patrick.robitaille |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: |
Description
Thatcher Rea
2012-01-20 21:29:23 UTC
Adding from the IRC logs: (3:34:35 PM) jcamins: If they use EBOOK, that might work. I'm not sure. (3:34:55 PM) trea: you think the issue is the hyphen? (3:35:05 PM) jcamins: It makes it a separate word. (3:36:22 PM) jcamins: Combined with the fact that ,phr doesn't actually use the phrase indexes, it just uses unfuzzy matching on the word index, BOOK logically *should* find results for E-BOOK. (3:36:30 PM) jcamins: I mean, given the way C4::Search works. (3:36:40 PM) jcamins: Since C4::Search is broken. (3:37:00 PM) jcamins: Because obviously that's not what it should be doing if the system worked the way we wanted it to. (3:38:09 PM) trea: so, to summate, dont' do that! (3:38:21 PM) trea: use unique strings for itype codes (3:38:55 PM) jcamins: Right. (3:39:17 PM) jcamins: Use unique strings for *all* authorized values. (3:39:44 PM) trea: add it to the bug :P (3:39:46 PM) jcamins: Or at least don't use any hyphens, if you feel you need similar codes. I don't think this is an enhancement - seems more like a bug to me. This is still an issue in master, 3.12 and 3.10. The same is true for shelving locations by the way - it seems that any similar codes are searched together. I don't think 'fixing' search would be easy here, I have to admit we also rely on that behaviour in at least one case. What we could do is add a warning when adding authorised values and item type codes that using hyphens and spaces can have unexpected consequences for search. Yeah this is a pet peeve of mine. (In reply to Katrin Fischer from comment #5) > I don't think 'fixing' search would be easy here, I have to admit we also > rely on that behaviour in at least one case. This sounds like treating a bug as a feature :/ |