Bug 7457

Summary: basket.pl makes a lot of noise in the logs
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Architecture, internals, and plumbingAssignee: Adrien SAURAT <adrien.saurat>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: normal    
Priority: P5 - low CC: adrien.saurat, paul.poulain
Version: 3.6   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: proposed patch
[SIGNED-OFF] Bug 7457: log cleaning on basket.pl

Description Katrin Fischer 2012-01-22 14:52:49 UTC
basket.pl throws lots of warns, we should fix it.


[Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $line{"left_holds"} in numeric eq (==) at /home/katrin/kohaclone/acqui/basket.pl line 285., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
[Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_rrp_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
[Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_rrp_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
[Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
[Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
[Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
[Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
[Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_rrp in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
[Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_rrp in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
Comment 1 Adrien SAURAT 2012-01-31 14:29:46 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-02-07 19:57:53 UTC
Created attachment 7493 [details] [review]
[SIGNED-OFF] Bug 7457: log cleaning on basket.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2012-02-07 20:00:24 UTC
I confirmed that basket.pl was leaving errors in the log. After the patch I tried opening, modifying, and closing a basket and saw no errors.
Comment 4 Ian Walls 2012-02-07 20:01:26 UTC
Sets default values of zero to various fields (rather than leaving them undefined).   Easy change, simple to read, marking Passed QA
Comment 5 Jared Camins-Esakov 2012-05-23 13:00:21 UTC
This fix was included in the 3.6.x branch prior to 3.6.4.