Summary: | nl2br in opac Title notes tab | ||
---|---|---|---|
Product: | Koha | Reporter: | Stéphane Delaune <stephane.delaune> |
Component: | OPAC | Assignee: | Stéphane Delaune <stephane.delaune> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | minor | ||
Priority: | P5 - low | CC: | adrien.saurat, chris, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
proposed patch
[SIGNED-OFF] Bug 7460: Add template toolkit's FILTER html_line_break on opac details description's tab followup patch for staff Bug 7460: followup : Add template toolkit's FILTER html_line_break on staff details description's tab |
Description
Stéphane Delaune
2012-01-23 14:51:04 UTC
url_opac/cgi-bin/koha/opac-detail.pl?biblionumber=1#descriptions tt includes a filter that works like a nl2br sub to replace \n with <br /> ; it's [% FILTER html_line_break %]. the patch use it Created attachment 7295 [details] [review] proposed patch Created attachment 7318 [details] [review] [SIGNED-OFF] Bug 7460: Add template toolkit's FILTER html_line_break on opac details description's tab Signed-off-by: Owen Leonard <oleonard@myacpl.org> I think the same change should be made to the staff client. Template only change, introducing new built-in filter. Marking as Passed QA Patch pushed. But I reset the status to assigned, as the same patch should be made for staff client, I agree with Owen. i'll mark your patch as obsolete as it has been pushed. Comment on attachment 7318 [details] [review] [SIGNED-OFF] Bug 7460: Add template toolkit's FILTER html_line_break on opac details description's tab this patch has been pushed. Now waiting for staff client similar patch Created attachment 7524 [details] [review] followup patch for staff Bug 7460: followup : Add template toolkit's FILTER html_line_break on staff details description's tab Created attachment 7754 [details] [review] Bug 7460: followup : Add template toolkit's FILTER html_line_break on staff details description's tab Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> QA comment: patch similar to OPAC one, passed QA This patch will be included in the forthcoming 3.6.5 release (no string changes). |