Bug 7476

Summary: Files executable that probably should not be
Product: Koha Reporter: MJ Ray (software.coop) <mjr>
Component: Architecture, internals, and plumbingAssignee: Aleksa Vujicic <aleksa>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P3 CC: m.de.rooy, mjr, paul.poulain
Version: master   
Hardware: All   
OS: All   
Change sponsored?: Seeking cosponsors Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: xt/find-misplaced-executables
Bug 7476 – Remove executable bit from files that probably should not be executed
[SIGNED-OFF] 7391: Bug 7476 – Remove executable bit from files that probably should not be executed
[PASSED_QA] Patch

Description MJ Ray (software.coop) 2012-01-30 20:59:53 UTC Comment hidden (obsolete)
Comment 1 MJ Ray (software.coop) 2012-01-30 21:07:40 UTC Comment hidden (obsolete)
Comment 2 Aleksa Vujicic 2012-01-31 03:19:24 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2012-02-03 12:44:11 UTC
Created attachment 7442 [details] [review]
[PASSED_QA] Patch
Comment 4 Marcel de Rooy 2012-02-03 12:45:11 UTC
Tested. Works as advertised. Amended patch to correct copy-and-paste comments.
Incrementing status..
Comment 5 Paul Poulain 2012-02-03 13:28:54 UTC
patch pushed, but my suggestion would be to also add
        '!' -name '*.*~' \
and 
        '!' -name '*.old' \
        '!' -name '*.bak' \

to the list of excluded files for xt/find-misplaced-executables

Do you think it could be a good idea ?
Comment 6 Jared Camins-Esakov 2012-12-31 00:34:18 UTC
There have been no further reports of problems so I am marking this bug resolved.