Summary: | Files executable that probably should not be | ||
---|---|---|---|
Product: | Koha | Reporter: | MJ Ray (software.coop) <mjr> |
Component: | Architecture, internals, and plumbing | Assignee: | Aleksa Vujicic <aleksa> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P3 | CC: | m.de.rooy, mjr, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Seeking cosponsors | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
xt/find-misplaced-executables
Bug 7476 – Remove executable bit from files that probably should not be executed [SIGNED-OFF] 7391: Bug 7476 – Remove executable bit from files that probably should not be executed [PASSED_QA] Patch |
Created attachment 7391 [details] [review] Bug 7476 – Remove executable bit from files that probably should not be executed Created attachment 7396 [details] [review] [SIGNED-OFF] 7391: Bug 7476 – Remove executable bit from files that probably should not be executed Created attachment 7442 [details] [review] [PASSED_QA] Patch Tested. Works as advertised. Amended patch to correct copy-and-paste comments. Incrementing status.. patch pushed, but my suggestion would be to also add '!' -name '*.*~' \ and '!' -name '*.old' \ '!' -name '*.bak' \ to the list of excluded files for xt/find-misplaced-executables Do you think it could be a good idea ? There have been no further reports of problems so I am marking this bug resolved. |
Created attachment 7390 [details] xt/find-misplaced-executables The following files are executable and I think they do not need to be. Please find attached an xt test that lists such misplaced executables. ./acqui/pdfformat/layout2pages.pm ./acqui/pdfformat/layout3pages.pm ./etc/zebradb/marc_defs/marc21/biblios/record.abs ./koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl ./koha-tmpl/opac-tmpl/prog/en/css/opac.css ./koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt ./koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt ./koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc ./installer/data/mysql/sysprefs.sql ./installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql ./installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql ./C4/Auth.pm ./C4/ImportExportFramework.pm ./C4/TTParser.pm ./C4/XSLT.pm