Summary: | The Basket manager is always the logged in user | ||
---|---|---|---|
Product: | Koha | Reporter: | Adrien SAURAT <adrien.saurat> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 7480: Don't display current logged in user as basket manager
[Signed-off] Bug 7480: Don't display current logged in user as basket manager [PASSED QA] Bug 7480: Don't display current logged in user as basket manager |
Description
Adrien SAURAT
2012-01-31 13:55:20 UTC
As seen with kf, getBasket builds authorisedbyname using concat( b.firstname,' ',b.surname) AS authorisedbyname, from borrowers So in both cases we have the same information. But maybe can problems arise if the borrower has been deleted -> to be handled. Still valid, something for a small clean-up patch: authorisedbyname => $basket->{'authorisedbyname'}, closedate => $basket->{'closedate'}, # order details suggestionid => $suggestion->{suggestionid}, surnamesuggestedby => $suggestion->{surnamesuggestedby}, firstnamesuggestedby => $suggestion->{firstnamesuggestedby}, biblionumber => $biblionumber, uncertainprice => $data->{'uncertainprice'}, authorisedbyname => $borrower->{'firstname'} . " " . $borrower->{'surname'}, Created attachment 37332 [details] [review] Bug 7480: Don't display current logged in user as basket manager The "Managed by" field displayed on creating/editing an order is always the name of the logged in user. To reproduce: 1/ Log in with patron A 2/ Create a basket 3/ Create an order 4/ Log in with patron B 5/ Edit the order 6/ The "Managed by" line is "patron B" Test plan: Apply the patch and confirm that the "patron A" is always the basket manager. Created attachment 37338 [details] [review] [Signed-off] Bug 7480: Don't display current logged in user as basket manager The "Managed by" field displayed on creating/editing an order is always the name of the logged in user. To reproduce: 1/ Log in with patron A 2/ Create a basket 3/ Create an order 4/ Log in with patron B 5/ Edit the order 6/ The "Managed by" line is "patron B" Test plan: Apply the patch and confirm that the "patron A" is always the basket manager. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 37511 [details] [review] [PASSED QA] Bug 7480: Don't display current logged in user as basket manager The "Managed by" field displayed on creating/editing an order is always the name of the logged in user. To reproduce: 1/ Log in with patron A 2/ Create a basket 3/ Create an order 4/ Log in with patron B 5/ Edit the order 6/ The "Managed by" line is "patron B" Test plan: Apply the patch and confirm that the "patron A" is always the basket manager. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Funny noone ever noticed the visible effect of this bug. Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.6 |