Summary: | overdues report downloads without names | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Circulation | Assignee: | Kyle M Hall <kyle.m.hall> |
Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
Severity: | major | ||
Priority: | P5 - low | CC: | gmcharlt, lzuares, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
URL: | cgi-bin/koha/circ/overdue.pl | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 7482 - overdues report downloads without names
Bug 7482: overdues report downloads without names [SIGNED-OFF] Bug 7482: overdues report downloads without names |
Description
Nicole C. Engard
2012-01-31 15:15:39 UTC
Created attachment 8685 [details] [review] Bug 7482 - overdues report downloads without names This bug is caused by the build_csv subroutine in overdue.pl using the hash key 'name' for the name field which does not exist. Fixed by adding the name field as a concatenation of firstname and surname to the loop that builds the array of hashrefs, @overduedata. It will be ignored by the Koha 'html' view of the overdue data and will only be used when exporting overdues to csv. Hi Kyle, I tested your patch and it works - I only think perhaps we can do it a bit better. I think having the name concatenated together is not really flexible for generating notices from this format or for sorting the data in a spreadsheet. Someone might want to generate notices using only the last name and borrowertitle. For this I propose a little different patch that gives 2 separate columns for first and last name. Created attachment 8744 [details] [review] Bug 7482: overdues report downloads without names This patch is an alternate patch for the bug. Instead of having one column 'name' for a concatenated first and last name it adds 2 separate columns to the exported csv file. Created attachment 8777 [details] [review] [SIGNED-OFF] Bug 7482: overdues report downloads without names This patch is an alternate patch for the bug. Instead of having one column 'name' for a concatenated first and last name it adds 2 separate columns to the exported csv file. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA comment: tiny patch *** Bug 7762 has been marked as a duplicate of this bug. *** This bug will be included in the Koha 3.6.5 release. |