Summary: | Cannot edit barcode on Fast Add | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <wizzyrea> |
Component: | Cataloging | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | critical | ||
Priority: | P1 - high | CC: | ago, brendan, kyle.m.hall, paul.poulain, wizzyrea |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 7485 - Cannot edit barcode on Fast Add
Bug 7485 - Cannot edit barcode on Fast Add Bug 7485 - Cannot edit barcode on Fast Add |
Description
Liz Rea
2012-01-31 17:07:48 UTC
Two other BWS sites have reported this problem: Marlboro College and Three Rivers. Looking into cataloguing/addbiblio.pm first. Created attachment 8649 [details] [review] Bug 7485 - Cannot edit barcode on Fast Add Simple fix, a special case was added for the fast add framework in the case that an item was being checked out that had not been catalogued. In that case, the barcode was being passed as a parameter through addbiblio.pl to additem.pl. This barcode param was used to overwrite the existing value, so if no barcode param was passed ( which is only the case with fast adds from the circ screen ), the barcode field would appear empty in the items editor. This commit causes that special case code to check for an existing barcode value first, and only use the cgi parameter 'branch' in the case that there is no existing barcode value. Created attachment 8650 [details] [review] Bug 7485 - Cannot edit barcode on Fast Add Simple fix, a special case was added for the fast add framework in the case that an item was being checked out that had not been catalogued. In that case, the barcode was being passed as a parameter through addbiblio.pl to additem.pl. This barcode param was used to overwrite the existing value, so if no barcode param was passed ( which is only the case with fast adds from the circ screen ), the barcode field would appear empty in the items editor. This commit causes that special case code to check for an existing barcode value first, and only use the cgi parameter 'branch' in the case that there is no existing barcode value. Created attachment 8653 [details] [review] Bug 7485 - Cannot edit barcode on Fast Add Simple fix, a special case was added for the fast add framework in the case that an item was being checked out that had not been catalogued. In that case, the barcode was being passed as a parameter through addbiblio.pl to additem.pl. This barcode param was used to overwrite the existing value, so if no barcode param was passed ( which is only the case with fast adds from the circ screen ), the barcode field would appear empty in the items editor. This commit causes that special case code to check for an existing barcode value first, and only use the cgi parameter 'branch' in the case that there is no existing barcode value. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Editing barcode of fast added item now works. Passes t xt Recommend this for 3.6 release. Simple change to a conditional to prevent execution in the cases described. marking Passed QA. patch pushed, and versionned for 3.6, it's a bug, not an ENH This bug will be included in the Koha 3.6.5 release. |