Summary: | Missing arguments in the pagination of receptions | ||
---|---|---|---|
Product: | Koha | Reporter: | Maxime Pelletier <pelletiermaxime> |
Component: | Acquisitions | Assignee: | Henri-Damien LAURENT <henridamien> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | normal | ||
Priority: | P5 - low | CC: | julian.maurice, koha, mjr, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Fix variable scope in the tt
New version of the initial patch - corrected for new master 3.6.x patch Bug 7548: Missing arguments when receiving orders |
Description
Maxime Pelletier
2012-02-15 21:52:30 UTC
Created attachment 7667 [details] [review] Fix variable scope in the tt Patch does not apply anymore on master. Can you rebase your patch and resubmit please? Created attachment 7951 [details] [review] New version of the initial patch - corrected for new master Created a new corrected version of this patch based on the current master. Vendor invoice and datereceived stay in URL when changing results per page or going to the next page. QA comment : tiny patch & good test plan but this patch overlap with the DataTable jquery plugin we should/want to use now. So I think this patch should be rewritten to use the jquery plugin marking failed QA see = wiki.koha-community.org/wiki/DataTables_HowTo Hi Paul, I think so short before feature freeze - perhaps worth fixing the bug and doing the datatables later? (In reply to comment #7) > Hi Paul, I think so short before feature freeze - perhaps worth fixing the > bug and doing the datatables later? correct & fair, will push this one now The patches for this bug do not apply to 3.6. If you want this included in 3.6.x, please rebase on 3.6.x and reset the version to rel_3_6. Created attachment 10064 [details] [review] 3.6.x patch Created attachment 10096 [details] [review] Bug 7548: Missing arguments when receiving orders Patch redone for 3.6.x to fix TT scoping problems and taking care of changed variable names (booksellerid vs supplierid). To test: Check pagination works correctly when receiving orders. Invoice number and date received should always appear in your URL and be shown at the top of the website. Signed-off-by: MJ Ray <mjr@phonecoop.coop> This patch will be in 3.6.6. |