Summary: | Remove wrong line endings in NORMARC record.abs | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | MARC Bibliographic data support | Assignee: | Magnus Enger <magnus> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 7537 | ||
Attachments: |
Bug 7552 - Remove wrong line endings in NORMARC record.abs
Bug 7552 - Remove wrong line endings in NORMARC record.abs Bug 7552 - Remove wrong line endings in NORMARC record.abs |
Description
Magnus Enger
2012-02-17 13:59:43 UTC
Created attachment 7711 [details] [review] Bug 7552 - Remove wrong line endings in NORMARC record.abs Line endings contain erroneous \r 's. Also remove a useless comment at the top of the file. This patch was produced by doing the following operations: git config --global core.autocrlf true git rm --cached -r etc/zebradb/marc_defs/normarc/biblios/record.abs git diff --cached --name-only -z | xargs -0 git add as recommended here: http://help.github.com/line-endings/ To test: - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in a file editor that will let you search for \r - gedit seems to work nicely for this. Check that there are occurences of \r in the file - Apply the patch - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in the editor and check that it can not find any \r Created attachment 7712 [details] [review] Bug 7552 - Remove wrong line endings in NORMARC record.abs Line endings contain erroneous \r 's. Also remove a useless comment at the top of the file. This patch was produced by doing the following operations: git config --global core.autocrlf true git rm --cached -r etc/zebradb/marc_defs/normarc/biblios/record.abs git diff --cached --name-only -z | xargs -0 git add as recommended here: http://help.github.com/line-endings/ First version of this file resulted in whitespaceerrors. Trying to fix that now. To test: - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in a file editor that will let you search for \r - gedit seems to work nicely for this. Check that there are occurences of \r in the file - Apply the patch - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in the editor and check that it can not find any \r Created attachment 7753 [details] [review] Bug 7552 - Remove wrong line endings in NORMARC record.abs Line endings contain erroneous \r 's. Also remove a useless comment at the top of the file. This patch was produced by doing the following operations: git config --global core.autocrlf true git rm --cached -r etc/zebradb/marc_defs/normarc/biblios/record.abs git diff --cached --name-only -z | xargs -0 git add as recommended here: http://help.github.com/line-endings/ First version of this file resulted in whitespaceerrors. Trying to fix that now. To test: - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in a file editor that will let you search for \r - gedit seems to work nicely for this. Check that there are occurences of \r in the file - Apply the patch - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in the editor and check that it can not find any \r Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Still a few \r But only on comments, safe to push QA comment: none, magnus will endorse responsibility for any mistake ;-) Looks good in current master. |