Summary: | Newlines break search paging | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | OPAC | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P3 | CC: | chris, m.de.rooy, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Example record
Bug 7554: Clean newlines in browse script Bug 7554: Clean newlines in browse script Signed patch |
Description
Jared Camins-Esakov
2012-02-17 15:53:56 UTC
Further investigation reveals that newlines in titles generally break search results in the OPAC. Created attachment 7742 [details] Example record You will need to add an item to this example record so that it shows up on Master (due to bug 6488). Created attachment 7743 [details] [review] Bug 7554: Clean newlines in browse script Records with a newline in the title will break the Javascript search pagination on the OPAC without this patch. To test: 1. Import a record with a newline in the title (an example is attached to this bug) 2. Do a search that turns up the record and at least one other 3. View the detail page for one of the other records 4. Observe that there is a javascript error 5. Apply patch 6. Repeat search 7. Observe that there is no javascript error Created attachment 7752 [details] [review] Bug 7554: Clean newlines in browse script Records with a newline in the title will break the Javascript search pagination on the OPAC without this patch. To test: 1. Import a record with a newline in the title (an example is attached to this bug) 2. Do a search that turns up the record and at least one other 3. View the detail page for one of the other records 4. Observe that there is a javascript error 5. Apply patch 6. Repeat search 7. Observe that there is no javascript error Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Simple template change, works well Created attachment 7774 [details] [review] Signed patch QA: Works. Small change. Marked as Passed QA. |