| Summary: | Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Liz Rea <wizzyrea> |
| Component: | OPAC | Assignee: | Bugs List <koha-bugs> |
| Status: | Patch doesn't apply --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, fridolin.somers, grace.mcky, rochellehealy.student, wizzyrea |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 4054 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 7556 - Use "preventDoubleFormSubmit()" more in the OPAC
Bug 7143: [QA Follow-up] Handling tabs |
||
That should read "bug 4054" instead of the 6k one. Updated the depends. I am working on this (In reply to Liz Rea from comment #0) > We should probably use this on most submission forms in the OPAC. Note that it has since been added to the place hold form in the OPAC. Created attachment 59289 [details] [review] Bug 7556 - Use "preventDoubleFormSubmit()" more in the OPAC Test Plan: - Look at commit to see file changes and then test each form making sure you can't double submit This is for the OPAC side The above patch is only for half of the bug, I decided to separate the OPAC and Staff sides of the bug to make it easier to see the changes made Created attachment 59290 [details] [review] Bug 7143: [QA Follow-up] Handling tabs Editing spaces before releases and developer: 876,$s/ \+releases$/^Ireleases/ (20 substitutions) 876,$s/ \+developer$/^Ideveloper/ (7 substitutions on 7 lines) Editing spaces between date and text: 876,$s/2016 \+/2016^I/ 876,$s/2017 \+/2017^I/ Fixed a few single spaces too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Display on Timeline tab looks good now. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> I am a bit confused by the changes to history.txt in this patch set, can someone explain? I am a bit confused by the changes to history.txt in this patch set, can someone explain? (In reply to Katrin Fischer from comment #8) > I am a bit confused by the changes to history.txt in this patch set, can > someone explain? Same for me. Forms double submit protection seems really usefull BTW. Can't we add this in all pages via opac-bottom.inc ? |
When 6496 is pushed, we will have a new jquery function: preventDoubleFormSubmit(). When used thusly: $('#form-id').preventDoubleFormSubmit(); It will prevent a submitted form from being submitted a second (or third, or fourth, or fifth) time. We should probably use this on most submission forms in the OPAC. As Paul states on 6496 - "we can teach librarians not to double click, but not patrons." The function exists in both the OPAC and Intranet, and so it can be used anywhere a double (or rapid) click would resubmit a form. I think we should try to use it more.