Summary: | tinymce editor broken in .deb packages - in 'en' templates | ||
---|---|---|---|
Product: | Koha | Reporter: | Thatcher Rea <thatcher.rea> |
Component: | Packaging | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | blocker | ||
Priority: | P1 - high | CC: | chris, magnus, mtj, paul.poulain, wizzyrea |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 7589 - tinymce editor broken in .deb packages - in 'en' templates
Bug 7589 - tinymce editor broken in .deb packages - in 'en' templates pix Signed off patch |
Description
Thatcher Rea
2012-02-23 21:48:18 UTC
6 levels of symbolic linking on a package install: http://screencast.com/t/DYcrZ4KTrkD Contrast that to a git install: http://screencast.com/t/CYfhjwQMLtwb (In reply to comment #1) > 6 levels of symbolic linking on a package install: > > http://screencast.com/t/DYcrZ4KTrkD > > Contrast that to a git install: > > http://screencast.com/t/CYfhjwQMLtwb we have also spotted this bug fyi: the french tinymce dir looks OK, its just the english dir thats got the borked symlinks Created attachment 9448 [details] [review] Bug 7589 - tinymce editor broken in .deb packages - in 'en' templates this patch fixes a glitchy symlink to tiny_mce Created attachment 9467 [details] [review] Bug 7589 - tinymce editor broken in .deb packages - in 'en' templates this patch fixes a glitchy symlink to tiny_mce I tried this patch, and it didn't seem to fix the problem. Created attachment 9548 [details]
pix
(In reply to comment #5) > I tried this patch, and it didn't seem to fix the problem. i just built and installed a Koha debian package, from these instruction... http://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way i applied this patch, and confirmed tiny_mce is now working screen-shot attached.... Hmm is this still a problem? Robin can you check, and elevate the severity if so please I just tested on an installation of 3.8.3 running off the official packages, and it has tiny_mce working beautifully for both English and Norwegian. Maybe this is just a problem for 3.6.x now? (In reply to comment #9) > I just tested on an installation of 3.8.3 running off the official packages, > and it has tiny_mce working beautifully for both English and Norwegian. > Maybe this is just a problem for 3.6.x now? well... looks like its still broken, in the latest stable .deb mason@gw1:~$ dpkg -c ./koha-common_3.8.3.1-1_all.deb |grep jscript |wc -l 0 what that '0' means is that there is ZERO dirs in the package called 'jscript' the 'jscript' dir gets deleted in ./debian/rules rm -r $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/js/tinymce which means that the below call for tiny_mce in ./prog/en/modules/tools/koha-news.tt will fail (which is the bug) script language="javascript" type="text/javascript" src="[% themelang %]/js /tinymce/jscripts/tiny_mce/tiny_mce.js"></script> and thats the bug, that the patch fixes The next line is: ln -s /usr/share/tinymce2/www \ $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/js/tinymce it's linking in the system copy of tinymce. (In reply to comment #9) > I just tested on an installation of 3.8.3 running off the official packages, > and it has tiny_mce working beautifully for both English and Norwegian. > Maybe this is just a problem for 3.6.x now? A little more digging reminded me that I made some non-standard symlinks at one time, forget my saying this works for me! (In reply to comment #9) > I just tested on an installation of 3.8.3 running off the official packages, > and it has tiny_mce working beautifully for both English and Norwegian. > Maybe this is just a problem for 3.6.x now? Magnus has confessed that he fixed this bug manually using symlinks :) so, 1) yes, its still confirmed busted in master 2) yes, the patch still fixes it (In reply to comment #11) > The next line is: > > ln -s /usr/share/tinymce2/www \ > > $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/js/tinymce > > it's linking in the system copy of tinymce. yep, its that *specific* line that has the bug :) (hint: the destination path is wrong) Created attachment 11549 [details] [review] Signed off patch In order for the patch to work, you must *REMOVE* koha-common, and reinstall from scratch. VERY IMPORTANT!!! The tabs in debian/rules are mandatory. Do not replace them with four spaces. Use -n when committing to skip pre-commit git hook verifications. VERY IMPORTANT!!!
> Created attachment 11549 [details] [review]
> Signed off patch
>
> In order for the patch to work, you must *REMOVE* koha-common, and reinstall
> from scratch.
>
> VERY IMPORTANT!!! The tabs in debian/rules are mandatory. Do not replace
> them with four spaces. Use -n when committing to skip pre-commit git hook
> verifications. VERY IMPORTANT!!!
bumping priority to an easy fix/sign-off patch
QA comment: * tiny patch related to debian building, no side-effect risk passed QA (note that the patch is declared as "octet-stream", not as patch. I had to apply it manually, git bz not working because there's no "patch") Patch pushed to master (In reply to comment #17) > QA comment: > * tiny patch related to debian building, no side-effect risk > > passed QA (note that the patch is declared as "octet-stream", not as patch. > I had to apply it manually, git bz not working because there's no "patch") thanks for that Paul fyi: you can edit any attachment, and 'tick the patch box', then save - to fix this 'octet-stream' problem Pushed to 3.8.x will be in 3.8.6 Works as expected, for English, Swedish and Norwegian (tested with packages built off current master). |