Summary: | System preferences editor JavaScript contains untranslatable English string | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 7596 - System prefs editor JS contains untranslatable English string
Bug 7596 - System prefs editor JS contains untranslatable English string Bug 7596 - System prefs editor JS contains untranslatable English string |
Description
Owen Leonard
2012-02-24 20:44:53 UTC
A larger problem is another js file used by preferences.pl: ajax.js. There are many instances where English strings are passed to the onscreen message handler: if ( error.type == 'auth' ) { humanMsg.displayMsg( _( 'You need to log in again, your session has timed out' ) ); } These messages should be moved to the template. Created attachment 16056 [details] [review] Bug 7596 - System prefs editor JS contains untranslatable English string There is one stray instance of an untranslatable string in preferences.js. This patch replaces it with a variable which is now defined in the preferences template. To test, open the system preferences editor and change any setting. You should see the usual "Saved preference <preference name>" message. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Created attachment 16106 [details] [review] Bug 7596 - System prefs editor JS contains untranslatable English string There is one stray instance of an untranslatable string in preferences.js. This patch replaces it with a variable which is now defined in the preferences template. To test, open the system preferences editor and change any setting. You should see the usual "Saved preference <preference name>" message. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tested both, all ok. QA comment: String appears in the po file after translate update. Marked as Passed QA. Created attachment 16163 [details] [review] Bug 7596 - System prefs editor JS contains untranslatable English string There is one stray instance of an untranslatable string in preferences.js. This patch replaces it with a variable which is now defined in the preferences template. To test, open the system preferences editor and change any setting. You should see the usual "Saved preference <preference name>" message. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tested both, all ok. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 |