Bug 7660

This is still an issue. I think we could solve this in different ways:

- Force to select a patron category before showing the form to add the child patron
- Use an Ajax call to reload the messaging preferences when the category is selected. But I have some doubts about this, as we only want to have 'initial' settings and respect if something has been changed manually.

*** Bug 4467 has been marked as a duplicate of this bug. ***

Confirming Comment 1 - this is still an issue, and is causing confusion for staff as they have to look up what the defaults should be for the different categories of patrons that are being added to the parent card.

Recently began having this issue. Digests will be checked when creating the guarantee but will uncheck once saved. Takes up staff time adding an additional step to sign up process.

(In reply to Emily W from comment #4)
> Recently began having this issue. Digests will be checked when creating the
> guarantee but will uncheck once saved. Takes up staff time adding an
> additional step to sign up process.

Hi Emily, I think this is a slightly different bug 30175 that was fixed in 22.05. I have also asked the RMaint to check for backporting. Which version did you test with?

One thing to note here, if the messaging preferences are left blank, then they are filled from the category on save

To test:
1 - In KTD set 'Juvenile' category to have some messaging preferences
2 - Find a patron, say Edna Acosta, and 'Add guarantee'
3 - In new form preferences are blank - fill out other fields and save
4 - Save patron
5 - Note messaging preferences match category defaults

(In reply to Katrin Fischer from comment #5)
> (In reply to Emily W from comment #4)
> > Recently began having this issue. Digests will be checked when creating the
> > guarantee but will uncheck once saved. Takes up staff time adding an
> > additional step to sign up process.
> 
> Hi Emily, I think this is a slightly different bug 30175 that was fixed in
> 22.05. I have also asked the RMaint to check for backporting. Which version
> did you test with?

We currently have 21.05 but will be updating to 21.11 on 7/27/22. Do you think the fix will come with that upgrade?

(In reply to Nick Clemens from comment #6)
> One thing to note here, if the messaging preferences are left blank, then
> they are filled from the category on save
> 
> To test:
> 1 - In KTD set 'Juvenile' category to have some messaging preferences
> 2 - Find a patron, say Edna Acosta, and 'Add guarantee'
> 3 - In new form preferences are blank - fill out other fields and save
> 4 - Save patron
> 5 - Note messaging preferences match category defaults

We've noticed that, but most of the juvenile cards we make we need to change the patron category, which auto fills everything in.

Created attachment 137801 [details] [review]
Bug 7660: Use first available categorycode when none passed in

The code that populates the patron messaging preferences on initial form load
expects to have a category selected. Currently we only have one if one was
passed to the form. When creating an account from a parent, we don't have a
category explicitly selected - so we can just select the first of the possible
categories

To test:
 1 - In KTD set 'Juvenile' category to have some messaging preferences
 2 - Find a patron, say Edna Acosta, and 'Add guarantee'
 3 - In new form preferences are blank, cancel
 4 - Apply patch, restart all
 5 - Go to Edna, click 'Add guarantee'
 6 - Preferences are populated!
 7 - Cancel
 8 - Go to 'Patrons' module
 9 - Click "+ New patron"
10 - Confirm messaging preferences load correctly when not adding child

(In reply to Nick Clemens from comment #9)
> Created attachment 137801 [details] [review] [review]
> Bug 7660: Use first available categorycode when none passed in
> 
> The code that populates the patron messaging preferences on initial form load
> expects to have a category selected. Currently we only have one if one was
> passed to the form. When creating an account from a parent, we don't have a
> category explicitly selected - so we can just select the first of the
> possible
> categories
> 
> To test:
>  1 - In KTD set 'Juvenile' category to have some messaging preferences
>  2 - Find a patron, say Edna Acosta, and 'Add guarantee'
>  3 - In new form preferences are blank, cancel
>  4 - Apply patch, restart all
>  5 - Go to Edna, click 'Add guarantee'
>  6 - Preferences are populated!
>  7 - Cancel
>  8 - Go to 'Patrons' module
>  9 - Click "+ New patron"
> 10 - Confirm messaging preferences load correctly when not adding child

Yes, everything works fine when we aren't creating using "add guarantee." All the categories have their default notification preferences correct in our settings.

Hi Emily,

That attachment was a patch to attempt to fix the problem and a supplied test plan. Did you apply the patch, or were just confirming current state of the bug?

-Nick

(In reply to Emily W from comment #10)
> (In reply to Nick Clemens from comment #9)
> > Created attachment 137801 [details] [review] [review] [review]
> > Bug 7660: Use first available categorycode when none passed in

(In reply to Nick Clemens from comment #11)
> Hi Emily,
> 
> That attachment was a patch to attempt to fix the problem and a supplied
> test plan. Did you apply the patch, or were just confirming current state of
> the bug?
> 
> -Nick
> 
> (In reply to Emily W from comment #10)
> > (In reply to Nick Clemens from comment #9)
> > > Created attachment 137801 [details] [review] [review] [review] [review]
> > > Bug 7660: Use first available categorycode when none passed in

Confirming the state, I will try the patch later today.

Created attachment 137821 [details] [review]
Bug 7660: Use first available categorycode when none passed in

The code that populates the patron messaging preferences on initial form load
expects to have a category selected. Currently we only have one if one was
passed to the form. When creating an account from a parent, we don't have a
category explicitly selected - so we can just select the first of the possible
categories

To test:
 1 - In KTD set 'Juvenile' category to have some messaging preferences
 2 - Find a patron, say Edna Acosta, and 'Add guarantee'
 3 - In new form preferences are blank, cancel
 4 - Apply patch, restart all
 5 - Go to Edna, click 'Add guarantee'
 6 - Preferences are populated!
 7 - Cancel
 8 - Go to 'Patrons' module
 9 - Click "+ New patron"
10 - Confirm messaging preferences load correctly when not adding child

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Works as described, signing off.

Thanks, Nick!

Created attachment 137841 [details] [review]
Bug 7660: Use first available categorycode when none passed in

The code that populates the patron messaging preferences on initial form load
expects to have a category selected. Currently we only have one if one was
passed to the form. When creating an account from a parent, we don't have a
category explicitly selected - so we can just select the first of the possible
categories

To test:
 1 - In KTD set 'Juvenile' category to have some messaging preferences
 2 - Find a patron, say Edna Acosta, and 'Add guarantee'
 3 - In new form preferences are blank, cancel
 4 - Apply patch, restart all
 5 - Go to Edna, click 'Add guarantee'
 6 - Preferences are populated!
 7 - Cancel
 8 - Go to 'Patrons' module
 9 - Click "+ New patron"
10 - Confirm messaging preferences load correctly when not adding child

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Don't get to pass QA on 4 digit bugs often anymore :)

Pushed to master for 22.11.

Nice work everyone, thanks!

Backported to 22.05.x for 22.05.05

thx pushed to 21.11.x for 21.11.12

Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.